james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Buchegger" <christian.bucheg...@planet-interkom.de>
Subject Re: [PATCH] NNTPHandler.java does not dispatch next command
Date Tue, 27 Aug 2002 18:37:29 GMT
Danny,

for a detailled explanation of the expected behavior have a look at the
9.1.1.3.2 NEXT Examples
in the draft-ietf-nntpext-base-13.txt.

In the first example the previous behavior would have returned the article
with the number 3000234
whereas with the fix, the first next command after selecting a group returns
the second article in
this group. This is my understanding from what I read in the examples.

Additonally I doubt that this would exhibit a regresseion, as the involved
code was never executed
before due to the missing dispatch of the next command.

Christian


----- Original Message -----
From: "Danny Angus" <danny@apache.org>
To: "James Developers List" <james-dev@jakarta.apache.org>
Sent: Monday, August 26, 2002 9:48 PM
Subject: RE: [PATCH] NNTPHandler.java does not dispatch next command


> Christian,
> I've commited this, but I'd appreciate you telling me what difference the
> pre-increment/post-increment  article number change makes.
> I know NNTP suffered from not displaying the first post to a group until a
> second post had been made, and hope this isn't going to revive that bug.
>
> d.
>   -----Original Message-----
>   From: Christian Buchegger
[mailto:christian.buchegger@planet-interkom.de]
>   Sent: 26 August 2002 20:30
>   To: james-dev@jakarta.apache.org
>   Subject: [PATCH] NNTPHandler.java does not dispatch next command
>
>
>   NNTPHandler.java does not dispatch the next command to the method
doNEXT.
>   Additionally the commands next and last behave like
>
>   send(header(CurrentArticleNumber++));
>
>   while they should behave like:
>
>   send(header(++CurrentArticleNumber));
>
>   The attached patch corrects both problems.
>
>   Christian
>
>


--
To unsubscribe, e-mail:   <mailto:james-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:james-dev-help@jakarta.apache.org>


Mime
View raw message