james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrei Ivanov" <my...@surfeu.fi>
Subject Contribution: Re: Handlers' streams RE: [Bug 11235]
Date Tue, 13 Aug 2002 22:09:24 GMT
Hi,
finally it's done (see attachment)

Comments:

Attached are only modified and new files for current James.
If you check out new james and copy src directory from zip over existing src
dir and build james distribution it will run right away.
When you'll look at sources you'll see what I've done. It is not well
commented in the code though...

There are two things you have to pay attention first of all

1. "connection" package structure doesn't correspond james structure where
interfaces defined in "services" and implementation is spread over other
packages (I've been always wandering why James originators hadn't adapted
cornerstone package structure from very beginning). So you may want to
modify connection package structure (move interfaces and implementations)

2. About SMTPHandler. I adapted only doAUTH(..) method from the latest James
(you will see it because it is shifted right). I think that most of the
recent changes were done to this method so I copied it from current James
and modified it according to my changes. If other methods have changed
recently you'll have to add those modifications to new SMTPHandler (use
doAUTH(..)  as an example).


Andrei

----- Original Message -----
From: "Andrei Ivanov" <myfam@surfeu.fi>
To: "James Developers List" <james-dev@jakarta.apache.org>
Sent: Monday, July 29, 2002 12:14 AM
Subject: Handlers' streams RE: [Bug 11235]


> Ok, then there will be
>
> 1. new AbstractServer
> 2. modified SMTPServer
> 3. modified SMTPHandler
> 4. modified MimeMessageInputStreamSource
> 5. modified SmsImpl (only one new constructor)
>
> There will be no changes in configs so that no compatibility hazards. Hope
> it will not be so little slow to apply these changes.
>
> How does this sound now?
>
> Heh, I would like to add to this logging levels for mailets, but this is
> totally another story ;-). I am just recalling  broken lances over mailet
> logging :-( ...to no avail.
>
> Andrei
>
> ----- Original Message -----
> From: "Danny Angus" <danny@apache.org>
> To: "James Developers List" <james-dev@jakarta.apache.org>
> Sent: Sunday, July 28, 2002 11:51 PM
> Subject: RE: [Bug 11235] Extensive use of string concatenation throughout
> code base
>
>
> >
> >
> > > I can
> > > provide fixed SMTPHandler (since I ve been working a lot with this
part
> of
> > > James for my project) so that other handlers can be fixed as well
> similar
> > > way. How does this sound?
> >
> > Andrei,
> > We're *always* happy to accept contributions.
> > If a little slow, at times, to apply them.
> >
> > d.
> >
> >
> > --
> > To unsubscribe, e-mail:
> <mailto:james-dev-unsubscribe@jakarta.apache.org>
> > For additional commands, e-mail:
> <mailto:james-dev-help@jakarta.apache.org>
> >
>
>
> --
> To unsubscribe, e-mail:
<mailto:james-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail:
<mailto:james-dev-help@jakarta.apache.org>
>


Mime
View raw message