james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter M. Goldstein" <peter_m_goldst...@yahoo.com>
Subject RE: [PATCH] SMTPHandler.java v.2
Date Tue, 06 Aug 2002 04:43:18 GMT

Hontvari,

> +    public final static String NAME_GIVEN = "NAME_GIVEN";     //
Remote
> host name provided by
> +                                                              //
client
> 
> You should follow the code conventions when commenting member
variables,
> otherwise they won't show up on javadocs, e.g. /** classVar1
documentation
> comment */

Actually I don't really want these comments to show up on javadocs.

I think the better solution is to make these fields private.  They are
exclusively for use in the SMTPHandler, so they actually shouldn't be
public.  Comments associated with private variables do not get displayed
in javadoc.

> 
> +                out.flush();
> +                logResponseString(responseString);
> 
> sometimes flushing and logging are in the opposite order in the patch.

Agreed, it should be uniform.  I've fixed that.

--Peter



--
To unsubscribe, e-mail:   <mailto:james-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:james-dev-help@jakarta.apache.org>


Mime
View raw message