james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harmeet Bedi" <harm...@kodemuse.com>
Subject Re: [PATCH] fields in XOVER containing newline or tab disturb client
Date Mon, 02 Sep 2002 01:39:03 GMT
From: Christian Buchegger 
Looking at RFC2980: 2.8 XOVER:

Good stuff. :)

Comments on this:
------------------
Also it uses a StringBuffer and a single call to prt.println()
instead many calls to prt.print(). This allowed to trace the communication between server
and client and finally
to find the problem.
------------------

I don't think prt.print(..) to StringBuffer makes a
difference. PrintWriter will buffer till println is called and it seems a bit cleaner.   

To debug NNTP protocol, it is best to change runscript to have system
property -Dapache.nntp.debug=true. Client and Server communication for
nntp will show up in the log file with prefix 'C: ' and 'S: '. This
should help identify protocol problems. Helped me a lot.

Harmeet


  ----- Original Message ----- 
  From: Christian Buchegger 
  To: James Developers List 
  Sent: Sunday, September 01, 2002 2:20 PM
  Subject: [PATCH] fields in XOVER containing newline or tab disturb client


  Hi,

  when experimenting with a larger number of real life articles, I observed the client to
stop getting 
  headers at a given point. Debugging into this I found out that these articles contained
either
  newline or tab characters in their titles.

  Looking at RFC2980: 2.8 XOVER I found:
  >> Note that any tab and end-of-line characters in any header data that
  >>    is returned will be converted to a space character.

  After filtering these characters from the response the client received the headers without
further complains.

  The attached patch does this filtering. Also it uses a StringBuffer and a single call to
prt.println()
  instead many calls to prt.print(). This allowed to trace the communication between server
and client and finally
  to find the problem.


  Rgs,

  Christian



------------------------------------------------------------------------------


  --
  To unsubscribe, e-mail:   <mailto:james-dev-unsubscribe@jakarta.apache.org>
  For additional commands, e-mail: <mailto:james-dev-help@jakarta.apache.org>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message