james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Darrell DeBoer <darr...@apache.org>
Subject Re: [PATCH][VOTE] AbstractJdbcUsersRepository.java
Date Sun, 24 Nov 2002 21:43:59 GMT
On Mon, 25 Nov 2002 06:04, Noel J. Bergman wrote:
> For those of you not following the thread on james-user, we found a JDBC
> resource leak that impacts Oracle users seriously (out of resources).
>
> As stated there on james-user:
>
> "This is a bug, and it really ought to be fixed.  The change is
> well-understood, used in all other areas, and easily tested.  We know that
> we have a number of Oracle users, and this is a resource leak for them.  I
> just checked my private tree against the CVS, and I don't have any other
> differences that would be termed a serious or potentially wide-spread
> defect.  We ought to vote on whether we would prefer to support the Release
> with or without the fix."
>
> The code is simply that there is one method (out of all the other similar
> places) where the common pattern we use everywhere else had not been
> implemented.  The change is attached, and consists of the following:
>
>   1. move two declarations out of a try block so that they
>      are available to the finally clause.
>
>   2. add the close statements to the existing finally clause.
>
> We have to support the Release.  I would prefer not to have to point Oracle
> users at a patch or immediately issue a point release.
>
> +1 to commit the change pending successful testing by the Oracle user who
> is working with us on james-user, as well as normal testing.
>
> 	--- Noel

+1
-- 
ciao,
Daz

--
To unsubscribe, e-mail:   <mailto:james-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:james-dev-help@jakarta.apache.org>


Mime
View raw message