james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Noel J. Bergman" <n...@devtech.com>
Subject RE: [PATCH/VOTE] - MX Chaining fix.
Date Mon, 11 Nov 2002 19:59:45 GMT
Peter,

I've now read the bug report and the code.  Seems reasonable.  However,
there are useful comments in the bug report that probably ought to be in the
code (or at least in the CVS).

Specifically: "there should be a separate try/catch block around the
transport.connect() statement, to handle connect errors separately from
errors that arise during message transmission.  Connect errors almost always
indicates that further SMTP servers associated with the MX record should be
tried, while errors in message transmission are generally protocol-level
errors that would occur with any SMTP server associated with the MX record
(the exception being IOExceptions that indicate a failure in the underlying
transport)" provides more elaboration than the current comments.

I guess I'm not a big fan of having the bug database as the only (or best)
source for why the code is as it is.

	--- Noel

-----Original Message-----
From: Peter M. Goldstein [mailto:peter_m_goldstein@yahoo.com]
Sent: Friday, November 08, 2002 16:45
To: 'James Developers List'
Subject: [PATCH/VOTE] - MX Chaining fix.



All,

This is a fix for bug #14381.  MX Chaining is broken for the reasons
explained in that bug report.  This patch separates the connect and the
send stages of the delivery and simplifies a large block of exception
handling code.  It's deliberately a fairly minimal change.  Were this
earlier in the cycle I'd suggest a more radical code change.  But this
one solves the problem and presents minimal risk.

As we are past code freeze, this requires a vote of the committers to be
accepted.  I think the problem is severe enough and the fix is localized
enough to merit a patch, so I vote +1.  Thoughts?

--Peter


--
To unsubscribe, e-mail:   <mailto:james-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:james-dev-help@jakarta.apache.org>


Mime
View raw message