james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harmeet Bedi" <harm...@kodemuse.com>
Subject Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api
Date Sat, 18 Jan 2003 19:22:43 GMT
Looks good but a few minor things
- I don't think there is any need to change DNServer interface to return a
list instead of collection. The results obtained are already sorted
according to priority and there is no need to do any more sorting. The
results returned are a collection of IP address so not sure what List to
collection does. Would prefer backward compatible API unless there is a real
gain.
- 'PriorityClass' instead of 'priorityClass' for class name.
- Avoid wildcard import.

Will commit it later today unless someone gets to it before.


One general question. Do we ever need to do autoritative lookups for MX
record ? Wouldn't that slow up.

Harmeet
----- Original Message -----
From: "Serge Sozonoff" <serge@globalbeach.com>
To: "James Developers List" <james-dev@jakarta.apache.org>
Sent: Wednesday, January 15, 2003 6:05 AM
Subject: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make
use of higher level api


> Hi All,
>
> Attached is a patch to upgrade to DnsJava 1.3.1
> The Patch also adds DNS Server autodetect, simplifys some code and takes
> care of some TODO items.
>
> DnsJava brings several bug fixes, the ChangeLog can be found here though
for
> some reason it only includes changes up
> until version 1.3.0 (http://www.xbill.org/dnsjava/Changelog)
>
> As fare as DNS autodetect goes, currently, this works if the OS has a
> unix-like /etc/resolv.conf, or the system is Windows based with ipconfig
or
> winipcfg.
>
> I am a little mixed up with the exact way we intend to handle to 2.1
branch
> so this patch was made against HEAD.
>
> Thanks,
> Sergei
>
>
>


----------------------------------------------------------------------------
----


> --
> To unsubscribe, e-mail:
<mailto:james-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail:
<mailto:james-dev-help@jakarta.apache.org>


--
To unsubscribe, e-mail:   <mailto:james-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:james-dev-help@jakarta.apache.org>


Mime
View raw message