james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Noel J. Bergman" <n...@devtech.com>
Subject RE: [PATCH] AddFooter enhancement
Date Sun, 09 Mar 2003 22:33:56 GMT

I am reviewing your submission.  It appears that this also fixes the problem
that Pierre Scherer has been reporting.

One question.  You removed the check for multipart/alternative as well as
adding the handling for MimeMultipart.  Wasn't just the latter change
necessary, and shouldn't the former have been kept?  For example, I don't
believe that you would want to run that loop on multipart/[related, signed,
encrypted, pgp, ...] parts.

Similarly, I'm wondering if the (part.getContent() instanceof MimeMultipart)
check ought to be a bit more selective.


	--- Noel

 -----Original Message-----
From: Mark Imel [mailto:mimel@imelshire.com]
Sent: Friday, February 14, 2003 14:58
To: James Developers List
Subject: [PATCH] AddFooter enhancement

The current AddFooter mailet is unable to successfully add its footer to
more complex mail messages:  specifically, any MimeMessage that has nested

These kinds of email messages may result when a user decides to use embedded
html elements with their email.  For instance, Outlook Express has a
Stationary feature that causes these complex MimeMessages to occur.

I came across this scenario, while building a [slightly] more advanced list
serv mailet that i hope to donate either to mailet.org or the james project.
I wanted to embed a standard mailing list footer (like you see with the
Jakarta mailing lists), and ensure that the footer is included regardless of
the type of mail sent to the list.

--mark imel

BTW: This is my first time submitting a patch to an apache project, i
apologize if i messed up the cvs diff file.  I'd be more than happy to send
the modified AddFooter if preferred, or regenerate the diff file if

To unsubscribe, e-mail: james-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: james-dev-help@jakarta.apache.org

View raw message