james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Noel J. Bergman" <n...@devtech.com>
Subject RE: [PATCH]Endless loop in JamesSpoolManager
Date Tue, 17 Jun 2003 17:29:37 GMT
Vincenzo,

    //We got an error... send it to the requested processor
+    if (!(e instanceof MessagingException)) {
+       //We got an error... send it to the error processor
+       mail.setState(Mail.ERROR);
+    }
     mail.setErrorMessage(e.getMessage());

Are you sure about this change?  It is correct in terms of the previous one,
but it points out a lack in the prior patch: not all Exceptions will be
MessagingExceptions.  Do we only want onException to catch
MessagingException instances, or do we want it to catch others?

	--- Noel

-----Original Message-----
From: Vincenzo Gianferrari Pini
[mailto:vincenzo.gianferraripini@praxis.it]
Sent: Tuesday, June 17, 2003 8:08
To: List James-Dev
Subject: [PATCH]Endless loop in JamesSpoolManager


The new "on{Match|Mailet}Exception" support introduced in 2.2.0a5 was
causing an endless "config.xml" loop caused by JamesSpoolManager not setting
state to Mail.ERROR in case of an Exception not instance of
MessagingException being thrown by a Mailet or Matcher. In such situation
the message was resent to the current processor instead of going to
Mail.ERROR.

Vincenzo


---------------------------------------------------------------------
To unsubscribe, e-mail: james-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: james-dev-help@jakarta.apache.org


Mime
View raw message