james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Noel J. Bergman (JIRA)" <server-...@james.apache.org>
Subject [jira] Commented: (JAMES-380) ESMTP Compliance fix
Date Thu, 02 Jun 2005 21:57:54 GMT
     [ http://issues.apache.org/jira/browse/JAMES-380?page=comments#action_66931 ]
     
Noel J. Bergman commented on JAMES-380:
---------------------------------------

This set of patches breaks the build.  Most patches applied, although the one for CRLFTerminatedReader
needed to be applied by hand.  However, after applying, the following error is observed:

/home/noel/ASF/james/server/trunk/src/java/org/apache/james/pop3server/POP3Handler.java:222:
incompatible types
found   : org.apache.james.util.CRLFTerminatedReader
required: java.io.BufferedReader
            in = new CRLFTerminatedReader(new BufferedInputStream(socket.getInputStream(),
512), "ASCII");
                 ^
1 error
1 warning

BUILD FAILED

and I cannot find a related patch for POP3Handler.java.

> ESMTP Compliance fix
> --------------------
>
>          Key: JAMES-380
>          URL: http://issues.apache.org/jira/browse/JAMES-380
>      Project: James
>         Type: Bug
>   Components: SMTPServer
>     Versions: 2.2.1
>     Reporter: Stefano Bagnara
>  Attachments: SMTPHandler.java.checkDSNRBLupdate.diff, esmtp-20050601.tar.gz
>
> Here is a cumulative patch for 
> [#JAMES-377] - rfc2034 ENHANCEDSTATUSCODES
> [#JAMES-375] - RFC 1854 - Command Pipelining support
> [#JAMES-374] - EHLO reply when SIZE limit is enabled is wrong
> [#JAMES-369] - Always announce AUTH capability to clients
> It also fixes a bug in MAIL FROM and RCPT TO attributes tokenizer.
> ---------------------------
>                  StringTokenizer optionTokenizer = new StringTokenizer(mailOptionString,
" ");
>                  while (optionTokenizer.hasMoreElements()) {
>                      String mailOption = optionTokenizer.nextToken();
> -                    int equalIndex = mailOptionString.indexOf('=');
> +                    int equalIndex = mailOption.indexOf('=');
> ------------------------------
> It clearly seems a bug.
> I think I have no rights to associate this issue to the 4 "childs".
> I'm creating this issue to have a place to append a single patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message