james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefano Bagnara" <apa...@bago.org>
Subject Re: [jira] Updated: (JAMES-380) ESMTP Compliance fix
Date Thu, 02 Jun 2005 16:04:11 GMT
> > > Did you see the patch I did to SMTPHandler earlier today? 
>  I haven't 
> > > committed it, but it seems that our patches need to be merged.
> 
> > Just replaced your
> > ...
> > And moved the check a few lines later.
> 
> I believe that you broke the code with that last change.  
> Please check me on this, since I plan to apply and then fix 
> the code again.
> 
> You moved the check inside the authRequired check.  I want it 
> OUTSIDE the check because I want for it to apply to ALL 
> e-mail, regardless of whether auth is required or not.

Here is your condition:

if (blocklisted &&                           // was found in the RBL
(authRequired && getUser() == null) &&   // not authenticated -- don't care
if it is local or not
!(recipientAddress.getUser().equalsIgnoreCase("postmaster") ||
recipientAddress.getUser().equalsIgnoreCase("abuse"))) {

I see that all the conditions are in "&&" and one of them is "authRequired".
I simply moved that code inside a block that already checked the
authRequired. I think I simply "refactored" your code with no change to the
behaviour.

I did not check your intended behaviour, I simply refactored it.

Am I missing something?

Stefano


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message