james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Serge Knystautas <sknystau...@gmail.com>
Subject Re: MailRepository notification/synchronization change (svn commit: r279353)
Date Wed, 07 Sep 2005 17:53:42 GMT
Awesome stuff.  Glad someone was finally able to track that one down.

-- 
Serge Knystautas
Lokitech >> software . strategy . design >> http://www.lokitech.com
p. 301.656.5501
e. sergek@lokitech.com

On 9/7/05, Stefano Bagnara <apache@bago.org> wrote:
> I've just committed a patch I created today.
> 
> The bug was both in file repositories and db repositories.
> Db repositories never sleeps forever so you simply had 60 seconds delay when
> the notification didn't work.
> 
> Adding a Thread.sleep(1000) after each notify() you can easily add evidence
> to notification issues.
> If you never noticed the problem then you probably are lucky enough with
> your thread timings.
> 
> I manually tested the spooling of single messages and ran stress-test to
> verify the impact on performance.
> Performance under stress are very similar.
> 
> Please test the change/review the code and report back any doubt.
> 
> I simply moved the notification to the "spool.unlock" method. I also added
> locking/unlocking to the spool.store method.
> I tryed to reduce differences between the file and db "synchronized" methods
> and locking policies.
> 
> Stefano
> 
> > Author: bago
> > Date: Wed Sep  7 08:43:55 2005
> > New Revision: 279353
> >
> > URL: http://svn.apache.org/viewcvs?rev=279353&view=rev
> > Log:
> > Fix for repository locks/notification/synchronization.
> > I've done stress-test and test with Thread.sleep() after the
> > notifications to ensure it is working but this is delicate
> > and we should test it more.
> > [...]

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message