james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefano Bagnara <apa...@bago.org>
Subject Re: [jira] Commented: (JAMES-426) Make james use virtual user table domains for servernames
Date Fri, 03 Feb 2006 12:47:29 GMT
> Daniel Perry commented on JAMES-426:
> ------------------------------------
> I agree.  The code i provided shouldn't affect any user of james, unless they add the
extra attribute, so therefore could be added without causing any problems.  I would suggest
that it is put to a vote on the dev list, but as i am not a commiter, I dont really have a
> Daniel.

I'm -0 on this patch.

It is true that this is backward compatible but if we introduce this way 
to handle the servernames we should take care to keep compatibility with 
this "hack" in future releases.

I don't like that "servernames" depends on VirtuserTable because they 
are unrelated services. I would not review/commit the current patch but 
I don't even put any veto on this.

I'm +0 on a modular way to handle the server names:
A modular way would be to create a DomainListProvider service and to add 
this dependency to the james server. Then create a default 
implementation that read the localservernames from the xml, and another 
one that read this list running a query on the virtusertable.

This feature is not in my priorities and I don't have time to write it, 
but I can help by reviewing and committing the code (if someone code it).


>> Attached is a patch that makes james use the virtualusertable database for identifying
local hosts.  It also allows for continued use of servernames block.  It is backwards compatible,
and unless an extra attribute is added in the configuration, it wont affect james's behaviour.
>> It is configured by adding the domainTable attribute to the servernames element,
>> <servernames autodetect="true" autodetectIP="true" domainTable="db://maildb/VirtualUserTable">
>> Please note that the patch i will attach against svn trunk, but has been copied over
directly from 2.2.0, and i havnt had a chance to check if it compiles or works with svn trunk.
>> Daniel.

To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org

View raw message