james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From b...@apache.org
Subject svn commit: r385656 - in /james/server/trunk/src/java/org/apache/james: fetchmail/FetchMail.java transport/mailets/LocalDelivery.java
Date Mon, 13 Mar 2006 20:47:57 GMT
Author: bago
Date: Mon Mar 13 12:47:55 2006
New Revision: 385656

URL: http://svn.apache.org/viewcvs?rev=385656&view=rev
Log:
Fixed possible comparison bugs with "string" == "string" (it probably worked due to jvm string
literal pool behaviour)

Modified:
    james/server/trunk/src/java/org/apache/james/fetchmail/FetchMail.java
    james/server/trunk/src/java/org/apache/james/transport/mailets/LocalDelivery.java

Modified: james/server/trunk/src/java/org/apache/james/fetchmail/FetchMail.java
URL: http://svn.apache.org/viewcvs/james/server/trunk/src/java/org/apache/james/fetchmail/FetchMail.java?rev=385656&r1=385655&r2=385656&view=diff
==============================================================================
--- james/server/trunk/src/java/org/apache/james/fetchmail/FetchMail.java (original)
+++ james/server/trunk/src/java/org/apache/james/fetchmail/FetchMail.java Mon Mar 13 12:47:55
2006
@@ -444,7 +444,7 @@
         {
             Configuration accountsChild = accountsChildren[i];
 
-            if (accountsChild.getName() == "alllocal")
+            if ("alllocal".equals(accountsChild.getName()))
             {
                 // <allLocal> is dynamic, save the parameters for accounts to
                 // be created when the task is triggered
@@ -453,7 +453,7 @@
                 continue;
             }
 
-            if (accountsChild.getName() == "account")
+            if ("account".equals(accountsChild.getName()))
             {
                 // Create an Account for the named user and
                 // add it to the list of static accounts

Modified: james/server/trunk/src/java/org/apache/james/transport/mailets/LocalDelivery.java
URL: http://svn.apache.org/viewcvs/james/server/trunk/src/java/org/apache/james/transport/mailets/LocalDelivery.java?rev=385656&r1=385655&r2=385656&view=diff
==============================================================================
--- james/server/trunk/src/java/org/apache/james/transport/mailets/LocalDelivery.java (original)
+++ james/server/trunk/src/java/org/apache/james/transport/mailets/LocalDelivery.java Mon
Mar 13 12:47:55 2006
@@ -88,9 +88,9 @@
              * @see org.apache.mailet.MailetConfig#getInitParameter(java.lang.String)
              */
             public String getInitParameter(String name) {
-                if (name == "addDeliveryHeader") {
+                if ("addDeliveryHeader".equals(name)) {
                     return "Delivered-To";
-                } else if (name == "resetReturnPath") {
+                } else if ("resetReturnPath".equals(name)) {
                     return "true";
                 } else {
                     return getMailetConfig().getInitParameter(name);



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message