james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Serge Knystautas" <sknystau...@gmail.com>
Subject Re: [jira] Updated: (JAMES-509) Cleanup/Refactor FetchMail code
Date Sat, 27 May 2006 15:04:59 GMT
Stefano,

I'm having trouble determining whether I think this is a helpful
refactoring based on the diffs.  Do you have a before and after
view?... maybe ViewSVN link to the point before you started to
changes, and then a download of the source afterward?

I like the idea of making the code formatted in a consistent pattern.
In terms of design patterns, I really don't care... I appreciate you
using a review-then-commit rather than commit-then-review on a change
this substantial (at least in # lines affected).

As a general comment though, I trust Stefano will do a good job with
the changes or will fix it promptly if he didn't.

-- 
Serge Knystautas
Lokitech >> software . strategy . design >> http://www.lokitech.com
p. 301.656.5501
e. sergek@lokitech.com

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message