james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefano Bagnara (JIRA)" <server-...@james.apache.org>
Subject [jira] Commented: (JAMES-463) Check for reverse on HELO/EHLO
Date Thu, 18 May 2006 23:08:07 GMT
    [ http://issues.apache.org/jira/browse/JAMES-463?page=comments#action_12412440 ] 

Stefano Bagnara commented on JAMES-463:
---------------------------------------

Not tested, only reviewed the patch file and here is the result:

1) I would use checkReverseEqualsEhlo instead of checkReverseEqualEhlo
2) You used tabs somewhere, please rememeber we use 4 spaces.
3) Try not to reformat code you don't touch: this make it easier to review the changes, avoid
conflicts, make is easy to find out in history why a give row contains a given code.

About the previous comment on the testability you can use a Mock DNSServer, like we did in
jSPF for that.

> Check for reverse on HELO/EHLO
> ------------------------------
>
>          Key: JAMES-463
>          URL: http://issues.apache.org/jira/browse/JAMES-463
>      Project: James
>         Type: New Feature

>   Components: SMTPServer
>     Reporter: Norman Maurer
>     Assignee: Norman Maurer
>      Fix For: 2.4.0
>  Attachments: helo-reverse.patch
>
> I complete a patch to support check that the provided helo is the reverse entry of the
connected mailserver. But anyone has an idea howto write a junit test for that ? Is there
a way to spoof the ip ? cause otherwise it will connect with 127.0.0.1 and this will fail
cause there is no valid reverse for that.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message