james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Norman Maurer ...@byteaction.de>
Subject Re: svn commit: r411096 - in /james/server/trunk/src/test/org/apache/james/transport/matchers: AbstractHasMailAttributeTest.java HasMailAttributeTest.java HasMailAttributeWithValueRegexTest.java HasMailAttributeWithValueTest.java
Date Fri, 02 Jun 2006 09:35:41 GMT
After review of your refctoring it seems that your abstract class seems
clearer and better structured as mine. Do you have other refactoring
allready done on the junit tests? IF yes plz commit yours I will drop
mine then. Or if not can you do it ?

bye
Norman

Am Freitag, den 02.06.2006, 11:16 +0200 schrieb Norman Maurer:
> Yeah i have more like this ;-) I will commit them later.. Just a bit
> tyred from last days ( we was working the whole night for getting iscsi
> up).
> 
> Thx anyway.. plz also commit this in the branch .
> bye
> Norman
> 
> Am Freitag, den 02.06.2006, 11:13 +0200 schrieb Bernd Fondermann:
> > Norman Maurer wrote:
> > > Thx Bernd,
> > > 
> > > i also had this here .. but not tested yet so not commited it ;-)
> > 
> > ah, ok. sorry, didn't want to step onto your feet... should've dropped a 
> > line in advance.
> > maybe you have even more like this. there seems to be some potential for 
> > more refactorings like these ;-)
> > 
> >    Bernd
> > 
> > > 
> > > 
> > > Am Freitag, den 02.06.2006, 08:54 +0000 schrieb berndf@apache.org:
> > > 
> > >>Author: berndf
> > >>Date: Fri Jun  2 01:54:54 2006
> > >>New Revision: 411096
> > >>
> > >>URL: http://svn.apache.org/viewvc?revA1096&view=rev
> > >>Log:
> > >>moved copy/paste-code into common superclass.
> > >>
> > >>Added:
> > >>    james/server/trunk/src/test/org/apache/james/transport/matchers/AbstractHasMailAttributeTest.java
> > >>Modified:
> > >>    james/server/trunk/src/test/org/apache/james/transport/matchers/HasMailAttributeTest.java
> > >>    james/server/trunk/src/test/org/apache/james/transport/matchers/HasMailAttributeWithValueRegexTest.java
> > >>    james/server/trunk/src/test/org/apache/james/transport/matchers/HasMailAttributeWithValueTest.java
> > >>
> > 
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> > For additional commands, e-mail: server-dev-help@james.apache.org
> > 
> > !EXCUBATOR:1,4480030137022109279675!

Mime
View raw message