james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From n...@apache.org
Subject svn commit: r473354 - /james/server/trunk/src/test/org/apache/james/smtpserver/SMTPServerTest.java
Date Fri, 10 Nov 2006 14:37:44 GMT
Author: noel
Date: Fri Nov 10 06:37:43 2006
New Revision: 473354

URL: http://svn.apache.org/viewvc?view=rev&rev=473354
Log:
JAMES-684.  The test isn't "broken".  It's very premise is flawed.  Added comment.

Modified:
    james/server/trunk/src/test/org/apache/james/smtpserver/SMTPServerTest.java

Modified: james/server/trunk/src/test/org/apache/james/smtpserver/SMTPServerTest.java
URL: http://svn.apache.org/viewvc/james/server/trunk/src/test/org/apache/james/smtpserver/SMTPServerTest.java?view=diff&rev=473354&r1=473353&r2=473354
==============================================================================
--- james/server/trunk/src/test/org/apache/james/smtpserver/SMTPServerTest.java (original)
+++ james/server/trunk/src/test/org/apache/james/smtpserver/SMTPServerTest.java Fri Nov 10
06:37:43 2006
@@ -1017,10 +1017,15 @@
         assertEquals("expected 250 ok", 250, smtpProtocol.getReplyCode());
 
     }
-/**
- * Noel please fix me!
- *  
-   
+
+    /*
+      REMOVED UNTIL FIXED.  This test assumes behavior that is wrong.
+      What we want to see is that for a given connection limit and a
+      given backlog, that connection limit requests are handled, and
+      that up to the backlog number of connections are queued.  More
+      connections than that would eventually error out (unless space
+      opened up in front of them during the TCP/IP handshake).
+
     public void testConnectionLimitExceeded() throws Exception {
         m_testConfiguration.setConnectionLimit(1); // allow no more than one connection at
a time 
         finishSetUp(m_testConfiguration);
@@ -1046,7 +1051,8 @@
         smtpProtocol2.connect("127.0.0.1", m_smtpListenerPort);
         assertTrue(smtpProtocol2.isConnected());
     }
-*/  
+    */
+    
     // RemoteDelivery tests.
     
     InMemorySpoolRepository outgoingSpool;



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message