james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Norman Maurer (JIRA)" <server-...@james.apache.org>
Subject [jira] Commented: (JAMES-558) MailImpl expose internal representation on getRecipients. This is a bad practice.
Date Fri, 29 Dec 2006 18:19:22 GMT
    [ http://issues.apache.org/jira/browse/JAMES-558?page=comments#action_12461423 ] 
Norman Maurer commented on JAMES-558:

We should fix this in next james release. The "correct" way whould be to use Collections.unmodifiableCollection(recipientCol);
to return the recipients collection. After that we need to add a addRecipient(MailAddress
rec) and removeRecipient(MailAddress rec) to the Mail interfaces. 

Any thoughts ?

> MailImpl expose internal representation on getRecipients. This is a bad practice.
> ---------------------------------------------------------------------------------
>                 Key: JAMES-558
>                 URL: http://issues.apache.org/jira/browse/JAMES-558
>             Project: James
>          Issue Type: Bug
>          Components: Mailet API, James Core
>            Reporter: Stefano Bagnara
>             Fix For: Trunk
> Currently our getRecipients expose the internal collection and it is used that way.
> To add recipients we use getRecipients().add(), to store multiple times a single mail
to different recipients we get the recipients collection and alter it between store of the
mail object (in RemoteDelivery).
> All of this seems to me bad practice and we should better encapsulate the recipients
list in the mail object.
> Maybe the simple way is to return immutable collections so we'll find bugs as soon as
possible and add methods to add and remove recipients directly in the mail interface.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org

View raw message