james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Burrell Donkin (JIRA)" <server-...@james.apache.org>
Subject [jira] Closed: (JAMES-780) [jSieve]
Date Sun, 08 Apr 2007 16:31:32 GMT

     [ https://issues.apache.org/jira/browse/JAMES-780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Burrell Donkin closed JAMES-780.
---------------------------------------

    Resolution: Fixed

Added line and column numbers to command and syntax exceptions.

> [jSieve] 
> ---------
>
>                 Key: JAMES-780
>                 URL: https://issues.apache.org/jira/browse/JAMES-780
>             Project: James
>          Issue Type: Improvement
>    Affects Versions: Trunk
>            Reporter: Robert Burrell Donkin
>         Assigned To: Robert Burrell Donkin
>            Priority: Minor
>         Attachments: jsieve-coordinate.patch
>
>
> i've managed to pass positional information through from the parser to the Command and
Test objects. my implementation uses ScriptCoordinate objects which contain details of line
and column numbers. when a problem occurs during the evaluation of Command and Test implementations,
this object is used to construct SyntaxException instances with positional information.
> it was necessary to add ScriptCoordinate to ExecutableCommand#execute and ExecutableTest#execute
as well as to objects in the inheritance hierarchy (AbstractCommand, AbstractTest and so on).

> this means breaking backwards compatibility
> it also means that altering the current pure, clean API design in a pragmatic (but inelegant)
fashion. probably the original APIs are superior and quite possibly once we start down this
route, more pragmatic changes will be needed later.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message