james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Norman Maurer <nor...@apache.org>
Subject Re: svn commit: r531444 - /james/mime4j/trunk/src/main/java/org/mime4j/util/CharsetUtil.java
Date Mon, 23 Apr 2007 12:37:24 GMT
You are right , but do you mean "ISO-8859-1" ?

bye
Norman


Bernd Fondermann schrieb:
> The second "if" should not be needed anymore.
>
> The javadoc suggests that the charset name is not "ISO8851-1" but
> "ISO-8851-1" (which is also required to be supported by every
> platform)
>
> FWIW, J1.5 has Charset.defaultCharset() which is not applicable for 1.4.
>
>  Bernd
>
> On 4/23/07, norman@apache.org <norman@apache.org> wrote:
>> Author: norman
>> Date: Mon Apr 23 05:11:16 2007
>> New Revision: 531444
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=531444
>> Log:
>> Use default charset of ISO8859-1 if charset could not retrived. Thx
>> to GX; -)
>>
>> Modified:
>>     james/mime4j/trunk/src/main/java/org/mime4j/util/CharsetUtil.java
>>
>> Modified:
>> james/mime4j/trunk/src/main/java/org/mime4j/util/CharsetUtil.java
>> URL:
>> http://svn.apache.org/viewvc/james/mime4j/trunk/src/main/java/org/mime4j/util/CharsetUtil.java?view=diff&rev=531444&r1=531443&r2=531444
>>
>> ==============================================================================
>>
>> --- james/mime4j/trunk/src/main/java/org/mime4j/util/CharsetUtil.java
>> (original)
>> +++ james/mime4j/trunk/src/main/java/org/mime4j/util/CharsetUtil.java
>> Mon Apr 23 05:11:16 2007
>> @@ -1119,10 +1119,11 @@
>>      }
>>
>>      public static java.nio.charset.Charset getCharset(String
>> charsetName) {
>> +        if(charsetName == null) charsetName = "ISO8859-1";
>> +
>>          java.nio.charset.Charset c =
>> java.nio.charset.Charset.forName(charsetName);
>>
>>          if (c == null) {
>> -            //TODO: Check what touse as default
>>              c = java.nio.charset.Charset.forName("ISO8859-1");
>>
>>          }
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>> For additional commands, e-mail: server-dev-help@james.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
>
> !DSPAM:1,462ca7aa324327258322836!
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message