james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Norman Maurer <nor...@apache.org>
Subject Re: [jira] Commented: (MIME4J-23) [JW#3] Drop lazy syntax checking or make it optional
Date Thu, 16 Aug 2007 05:16:26 GMT
Hi Robert,

jumped in ;-)

I loke more the mime4j-event.patch. But there is something which seems 
to be incorrect:

+    /**
+     * Logs (at debug) an indicative message based on the given event
+     * and the current state of the system.
+     * @param event <code>Event</code>, not null
+     */
+    protected void debug(Event event) {
+        if (log.isWarnEnabled()) {
+            log.warn(message(event));
+        }
+    }

should be :

+    /**
+     * Logs (at debug) an indicative message based on the given event
+     * and the current state of the system.
+     * @param event <code>Event</code>, not null
+     */
+    protected void debug(Event event) {
+        if (log.isDebugEnabled()) {
+            log.debug(message(event));
+        }
+    }

bye
Norman


Robert Burrell Donkin schrieb:
> unless anyone jumps in the sometime soon, i'm likely to commit
> something along the lines i've suggested...
>
> On 8/14/07, Robert Burrell Donkin (JIRA) <server-dev@james.apache.org> wrote:
>   
>>     [ https://issues.apache.org/jira/browse/MIME4J-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519765
]
>>
>> Robert Burrell Donkin commented on MIME4J-23:
>> ---------------------------------------------
>>
>> Which approach is better?
>>
>> Opinions?
>>
>> Robert
>>
>>     
>>> [JW#3]  Drop lazy syntax checking or make it optional
>>> -----------------------------------------------------
>>>
>>>                 Key: MIME4J-23
>>>                 URL: https://issues.apache.org/jira/browse/MIME4J-23
>>>             Project: Mime4j
>>>          Issue Type: Wish
>>>            Reporter: Robert Burrell Donkin
>>>         Attachments: mime4j-event.patch, mime4j-strict.patch
>>>
>>>
>>> http://mail-archives.apache.org/mod_mbox/james-server-dev/200708.mbox/%3ce75283b10708051908w38b3b7b5l31ef423d33efe014@mail.gmail.com%3e
#3
>>> 3.) Drop lazy syntax checking or make it optional
>>>       Mime4j has a lot of places where it detects syntax errors of the
>>>       multipart stream. Currently, these are reported by a warning message,
>>>       which is being logged.
>>>       This behaviour is improper. Such situations should cause an
>>> exception or at
>>>       least the Mime4j user should be able to request that they do.
>>>       
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>> For additional commands, e-mail: server-dev-help@james.apache.org
>>
>>
>>     
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
>
> !DSPAM:1,46c35f73240377079819688!
>
>
>   


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message