james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nor...@apache.org
Subject svn commit: r573331 - in /james/jspf/trunk/src: main/java/org/apache/james/jspf/ main/java/org/apache/james/jspf/core/ main/java/org/apache/james/jspf/impl/ main/java/org/apache/james/jspf/policies/ test/java/org/apache/james/jspf/
Date Thu, 06 Sep 2007 18:25:48 GMT
Author: norman
Date: Thu Sep  6 11:25:47 2007
New Revision: 573331

URL: http://svn.apache.org/viewvc?rev=573331&view=rev
Log:
Fix some visibilities...
Fix some typos
Add visibility modifier's to be more "inline" with other coding style in this project

Modified:
    james/jspf/trunk/src/main/java/org/apache/james/jspf/SPF.java
    james/jspf/trunk/src/main/java/org/apache/james/jspf/core/Configurable.java
    james/jspf/trunk/src/main/java/org/apache/james/jspf/core/Directive.java
    james/jspf/trunk/src/main/java/org/apache/james/jspf/core/FutureSPFResult.java
    james/jspf/trunk/src/main/java/org/apache/james/jspf/core/Logger.java
    james/jspf/trunk/src/main/java/org/apache/james/jspf/core/SPFChecker.java
    james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSServiceAsynchSimulator.java
    james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSServiceXBillImpl.java
    james/jspf/trunk/src/main/java/org/apache/james/jspf/policies/SPFRetriever.java
    james/jspf/trunk/src/test/java/org/apache/james/jspf/ConsoleLogger.java

Modified: james/jspf/trunk/src/main/java/org/apache/james/jspf/SPF.java
URL: http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/SPF.java?rev=573331&r1=573330&r2=573331&view=diff
==============================================================================
--- james/jspf/trunk/src/main/java/org/apache/james/jspf/SPF.java (original)
+++ james/jspf/trunk/src/main/java/org/apache/james/jspf/SPF.java Thu Sep  6 11:25:47 2007
@@ -218,13 +218,13 @@
 
     }
 
-    DNSService dnsProbe;
+    private DNSService dnsProbe;
 
     public SPFRecordParser parser;
 
-    Logger log;
+    private Logger log;
     
-    String defaultExplanation = null;
+    private String defaultExplanation = null;
     
     public boolean useBestGuess = false;
 

Modified: james/jspf/trunk/src/main/java/org/apache/james/jspf/core/Configurable.java
URL: http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/core/Configurable.java?rev=573331&r1=573330&r2=573331&view=diff
==============================================================================
--- james/jspf/trunk/src/main/java/org/apache/james/jspf/core/Configurable.java (original)
+++ james/jspf/trunk/src/main/java/org/apache/james/jspf/core/Configurable.java Thu Sep  6
11:25:47 2007
@@ -33,6 +33,6 @@
      * @param params the ConfigurationMatch which should used
      * @throws PermErrorException get thrown if a PermError should returned
      */
-    void config(Configuration params) throws PermErrorException;
+    public void config(Configuration params) throws PermErrorException;
 
 }

Modified: james/jspf/trunk/src/main/java/org/apache/james/jspf/core/Directive.java
URL: http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/core/Directive.java?rev=573331&r1=573330&r2=573331&view=diff
==============================================================================
--- james/jspf/trunk/src/main/java/org/apache/james/jspf/core/Directive.java (original)
+++ james/jspf/trunk/src/main/java/org/apache/james/jspf/core/Directive.java Thu Sep  6 11:25:47
2007
@@ -134,14 +134,4 @@
         return qualifier + mechanism;
     }
 
-    /*
-     * TODO: Can we remove this ?
-     * 
-    public void onDNSResponse(DNSResponse response, SPFSession spfSession)
-            throws PermErrorException, NoneException, TempErrorException,
-            NeutralException {
-        throw new IllegalStateException("NOT USED YET");
-    }
-    */
-
 }

Modified: james/jspf/trunk/src/main/java/org/apache/james/jspf/core/FutureSPFResult.java
URL: http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/core/FutureSPFResult.java?rev=573331&r1=573330&r2=573331&view=diff
==============================================================================
--- james/jspf/trunk/src/main/java/org/apache/james/jspf/core/FutureSPFResult.java (original)
+++ james/jspf/trunk/src/main/java/org/apache/james/jspf/core/FutureSPFResult.java Thu Sep
 6 11:25:47 2007
@@ -26,7 +26,7 @@
  */
 public class FutureSPFResult extends SPFResult {
     
-    boolean isReady;
+    private boolean isReady;
     
     public FutureSPFResult() {
         isReady = false;

Modified: james/jspf/trunk/src/main/java/org/apache/james/jspf/core/Logger.java
URL: http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/core/Logger.java?rev=573331&r1=573330&r2=573331&view=diff
==============================================================================
--- james/jspf/trunk/src/main/java/org/apache/james/jspf/core/Logger.java (original)
+++ james/jspf/trunk/src/main/java/org/apache/james/jspf/core/Logger.java Thu Sep  6 11:25:47
2007
@@ -31,7 +31,7 @@
      * @param message
      *            the message
      */
-    void debug(String message);
+    public void debug(String message);
 
     /**
      * Log a debug message.
@@ -41,14 +41,14 @@
      * @param throwable
      *            the throwable
      */
-    void debug(String message, Throwable throwable);
+    public void debug(String message, Throwable throwable);
 
     /**
      * Determine if messages of priority "debug" will be logged.
      * 
      * @return true if "debug" messages will be logged
      */
-    boolean isDebugEnabled();
+    public boolean isDebugEnabled();
 
     /**
      * Log a info message.
@@ -56,7 +56,7 @@
      * @param message
      *            the message
      */
-    void info(String message);
+    public void info(String message);
 
     /**
      * Log a info message.
@@ -66,14 +66,14 @@
      * @param throwable
      *            the throwable
      */
-    void info(String message, Throwable throwable);
+    public void info(String message, Throwable throwable);
 
     /**
      * Determine if messages of priority "info" will be logged.
      * 
      * @return true if "info" messages will be logged
      */
-    boolean isInfoEnabled();
+    public boolean isInfoEnabled();
 
     /**
      * Log a warn message.
@@ -81,7 +81,7 @@
      * @param message
      *            the message
      */
-    void warn(String message);
+    public void warn(String message);
 
     /**
      * Log a warn message.
@@ -91,14 +91,14 @@
      * @param throwable
      *            the throwable
      */
-    void warn(String message, Throwable throwable);
+    public void warn(String message, Throwable throwable);
 
     /**
      * Determine if messages of priority "warn" will be logged.
      * 
      * @return true if "warn" messages will be logged
      */
-    boolean isWarnEnabled();
+    public boolean isWarnEnabled();
 
     /**
      * Log a error message.
@@ -106,7 +106,7 @@
      * @param message
      *            the message
      */
-    void error(String message);
+    public void error(String message);
 
     /**
      * Log a error message.
@@ -116,14 +116,14 @@
      * @param throwable
      *            the throwable
      */
-    void error(String message, Throwable throwable);
+    public void error(String message, Throwable throwable);
 
     /**
      * Determine if messages of priority "error" will be logged.
      * 
      * @return true if "error" messages will be logged
      */
-    boolean isErrorEnabled();
+    public boolean isErrorEnabled();
 
     /**
      * Log a fatalError message.
@@ -131,7 +131,7 @@
      * @param message
      *            the message
      */
-    void fatalError(String message);
+    public void fatalError(String message);
 
     /**
      * Log a fatalError message.
@@ -141,14 +141,14 @@
      * @param throwable
      *            the throwable
      */
-    void fatalError(String message, Throwable throwable);
+    public void fatalError(String message, Throwable throwable);
 
     /**
      * Determine if messages of priority "fatalError" will be logged.
      * 
      * @return true if "fatalError" messages will be logged
      */
-    boolean isFatalErrorEnabled();
+    public boolean isFatalErrorEnabled();
 
     /**
      * Create a new child logger. The name of the child logger is
@@ -159,5 +159,5 @@
      *            the subname of this logger
      * @return the new logger
      */
-    Logger getChildLogger(String name);
+    public Logger getChildLogger(String name);
 }

Modified: james/jspf/trunk/src/main/java/org/apache/james/jspf/core/SPFChecker.java
URL: http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/core/SPFChecker.java?rev=573331&r1=573330&r2=573331&view=diff
==============================================================================
--- james/jspf/trunk/src/main/java/org/apache/james/jspf/core/SPFChecker.java (original)
+++ james/jspf/trunk/src/main/java/org/apache/james/jspf/core/SPFChecker.java Thu Sep  6 11:25:47
2007
@@ -46,14 +46,4 @@
      */
     public DNSLookupContinuation checkSPF(SPFSession spfData) throws PermErrorException,
             TempErrorException, NeutralException, NoneException;
-
-//    TODO: Can we remove this ?
-    
-//    /**
-//     * Temporary, to evaluate impact on the redesign.
-//     */
-//    public void onDNSResponse(DNSResponse response, SPFSession spfSession)
-//            throws PermErrorException, NoneException, TempErrorException,
-//            NeutralException;
-//
 }

Modified: james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSServiceAsynchSimulator.java
URL: http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSServiceAsynchSimulator.java?rev=573331&r1=573330&r2=573331&view=diff
==============================================================================
--- james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSServiceAsynchSimulator.java
(original)
+++ james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSServiceAsynchSimulator.java
Thu Sep  6 11:25:47 2007
@@ -29,7 +29,7 @@
 import java.util.LinkedList;
 
 /**
- * Wrap a DNSService an excute the calls asynch in a new Thread
+ * Wrap a DNSService an execute the calls asynch in a new Thread
  * 
  */
 public class DNSServiceAsynchSimulator implements Runnable, DNSAsynchLookupService {

Modified: james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSServiceXBillImpl.java
URL: http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSServiceXBillImpl.java?rev=573331&r1=573330&r2=573331&view=diff
==============================================================================
--- james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSServiceXBillImpl.java (original)
+++ james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSServiceXBillImpl.java Thu
Sep  6 11:25:47 2007
@@ -151,7 +151,13 @@
             return null;
         }
     }
-
+    
+    /**
+     * Convert the given Record array to a List
+     * 
+     * @param rr Record array
+     * @return list
+     */
     public static List convertRecordsToList(Record[] rr) {
         List records;
         if (rr != null && rr.length > 0) {
@@ -191,5 +197,4 @@
         }
         return records;
     }
-
 }

Modified: james/jspf/trunk/src/main/java/org/apache/james/jspf/policies/SPFRetriever.java
URL: http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/policies/SPFRetriever.java?rev=573331&r1=573330&r2=573331&view=diff
==============================================================================
--- james/jspf/trunk/src/main/java/org/apache/james/jspf/policies/SPFRetriever.java (original)
+++ james/jspf/trunk/src/main/java/org/apache/james/jspf/policies/SPFRetriever.java Thu Sep
 6 11:25:47 2007
@@ -86,11 +86,11 @@
         
     }
 
-		/**
-		 * This is used for testing purpose. Setting this to true will skip the initial
-		 * lookups for SPF records and instead will simply check the TXT records.
-		 */
-		private static final boolean CHECK_ONLY_TXT_RECORDS = false;
+	/**
+	 * This is used for testing purpose. Setting this to true will skip the initial
+	 * lookups for SPF records and instead will simply check the TXT records.
+	 */
+	private static final boolean CHECK_ONLY_TXT_RECORDS = false;
     
     /**
      * Return the extracted SPF-Record 

Modified: james/jspf/trunk/src/test/java/org/apache/james/jspf/ConsoleLogger.java
URL: http://svn.apache.org/viewvc/james/jspf/trunk/src/test/java/org/apache/james/jspf/ConsoleLogger.java?rev=573331&r1=573330&r2=573331&view=diff
==============================================================================
--- james/jspf/trunk/src/test/java/org/apache/james/jspf/ConsoleLogger.java (original)
+++ james/jspf/trunk/src/test/java/org/apache/james/jspf/ConsoleLogger.java Thu Sep  6 11:25:47
2007
@@ -26,9 +26,8 @@
  * This is mainly for the cases when you have a utility that
  * does not have a logger to supply.
  */
-public final class ConsoleLogger
-    implements Logger
-{
+public final class ConsoleLogger implements Logger {
+    
     /** Typecode for debugging messages. */
     public static final int LEVEL_DEBUG = 0;
 



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message