james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefano Bagnara <apa...@bago.org>
Subject [jSieve] remove cycles in three moves
Date Tue, 18 Sep 2007 11:18:59 GMT
Currently there are 7 cyclic dependencies between packages.

I found this refactoring removes all of them:

1) Create an "jsieve.exception" package to include exception classes
from the jsieve main package (jsieve.*Exception)

2) Move MatchTypeTags from test to comparators

3) Move CommandStateManager, ConditionManager and ExecutableCommand from
"commands" to the main package.

At this point the main package classes (jsieve) could be splitted in 2
different packages because they cover both the high and the low level of
the architecture, but this is not required to remove cycles, so I
propose to do the 3 steps now, and then see if it worth doing more or not.

WDYT?

Stefano


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message