james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Fondermann" <bernd.fonderm...@googlemail.com>
Subject Re: [jSPF] refactoring to remove cyclic dependencies and find a better structure
Date Mon, 17 Sep 2007 10:06:10 GMT
Stefano,

thanks for taking care of all this.
I will review commits I did not already visit yet later.

  Bernd

On 9/17/07, Stefano Bagnara <apache@bago.org> wrote:
> Stefano Bagnara ha scritto:
> > I'm trying to reorganize code for jSPF in order to be able to provide
> > some sort of architectural documentation and to remove cyclic
> > dependencies between packages.
> >
> > As you can see from the last 2 commits this means moving around a lot of
> > classes.
>
> I played with the big class dependency graph and with some custom code
> to run com.sun.jini.tool.ClassDep against each one of our jSPF classes
> and export the result in GraphML to visualize it with yEd and using its
> facilities to optimize the rendering of a graph.
>
> This helped me re-clustering classes in different packages so to reduce
> the application packages layers.
>
> After the moves I also added some basic dev documentation.
>
> > I also plan to do some renaming if I find better names.
>
> I only renamend Configurable to ConfigurationEnabled to follow the
> naming convention used in the rest of the code for enabling interfaces.
>
> > I will work with a CTR approach as most changes are better understood
> > checking out the updated tree.
>
> Everything is there. After you will have reviewed this, if everything is
> ok we can try releasing it.
>
> One thing that could be improved is the command line usage/argument help
> for the main spf command line. I this the configuration I used for
> DNSTestingServerLauncher is a bit better than the one used in SPFQuery
> (usage in DNSTestingServerLauncher is automatically managed by the cli
> library).
>
> I also ran RAT, but I will post another message to track this.
>
> Stefano
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message