james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Burrell Donkin" <robertburrelldon...@gmail.com>
Subject Re: [JAMESHandler] Streams in AbstractJamesHandler
Date Sat, 05 Apr 2008 21:34:11 GMT
On Sat, Apr 5, 2008 at 9:53 PM, Danny Angus <danny@apache.org> wrote:
> On Sat, Apr 5, 2008 at 10:19 AM, Robert Burrell Donkin
>  <robertburrelldonkin@gmail.com> wrote:
>  >  #6 uses Buffered streams for IO.
>  >   6A the buffer size is hard coded. this is ok or does it need to be
>  >  configurable?
>
>  Its probably OK, assuming that we understand the normal patterns of
>  data we expect to be reading, and we don;t really want to confuse
>  people with too many esoteric config params.
>  OTOH making it configurable would allow people to be optimised for
>  patterns which don't fit our model.

good points, well made

sounds like it might be best to allow subclasses to vary the value (to
allow developers to tune) but not allow users to configure it

- robert

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message