james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefano Bagnara (JIRA)" <server-...@james.apache.org>
Subject [jira] Commented: (JAMES-840) Alternate approach to local private repo for mvn build
Date Mon, 16 Jun 2008 08:59:45 GMT

    [ https://issues.apache.org/jira/browse/JAMES-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605226#action_12605226
] 

Stefano Bagnara commented on JAMES-840:
---------------------------------------

#1  The real dependencies are already explained in each module pom file, so there is no need
to have separate stage folder for each module, but, maybe this does not apply to the phoenix-deployment/phoenix-bin
folder: this is simply a local copy of the latest phoenix distribution (with few patches by
us). This is a container and is not needed at build time but only at runtime. I don't want
to place this stuff in our stage folder / repository, or, at most, I would add the whole folder
(phoenix distribution) as an archive (tar.gz) and not each single jar.
- IMHO the avalon-spring bridge/container could be even moved to its own project: I think
there are other projects around the world based on avalon that would pay gold for it and they
currently can't find it because it is part of a never released trunk folder in our svn.
- About the spring-deployment/lib folder I would like to see it removed: maybe the phoenix-runtime
content can be reduced to the minimal set required to run the spring container and moved to
the main stage folder.

#2 I described Pro/Cons in a previous comment. ATM +0.5 to do what you propose. This still
will be an hack, but this at least isolate the hack into a single module. We have to check
that this does not introduce other issues (try to build it with an empty local repository
and see it works fine).

#2.1: for sure it worth labelling the jars appropriately but I wouldn't like to split stage
into 2 different folders because of this "dynamic" classification: each jar could be published
to central if someone take care of doing this.

That said I think geronimo integration is a very good thing to have, so I would be +0.5 to
apply this patch as is and then try to fix my concerns as part of separate tasks.

> Alternate approach to local private repo for mvn build
> ------------------------------------------------------
>
>                 Key: JAMES-840
>                 URL: https://issues.apache.org/jira/browse/JAMES-840
>             Project: James
>          Issue Type: Bug
>          Components: Build System
>    Affects Versions: Trunk
>            Reporter: David Jencks
>         Attachments: JAMES-840-2.patch, JAMES-840.patch
>
>
> The mvn build did not work for me, perhaps because of some maven proxy settings.  However
I think the current use of local repositories is weird and suggest an alternate approach,
see attachment.
> Basically the idea is to turn stage into a project that installs all required jars from
the stage private local repo to the local maven repo.
> I would suggest having two sets of dependencies: in the regular dependencies include
only those jars that are not available elsewhere, and in a profile include also those jars
that are available from maven central.  This will clarify which jars you are using from non-publically-available
sources or builds.
> In addition, the spring integration has a separate stage.  I would recommend moving the
contents to the main stage repo with (I think)
> svn mv spring-deployment/stage/ stage
> I don't know if this would break the ant build.
> At this point the root pom is missing the javax.jcr:jcr:1.0:jar and avalon-phoenix:avalon-phoenix-client:4.2-SNAPSHOT:jar
dependencies in the dependency management section

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message