james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Burrell Donkin" <robertburrelldon...@gmail.com>
Subject Re: svn commit: r667819 - in /james/jsieve/trunk: build.xml maven-build.bnd stage/aQute/ stage/aQute/jars/ stage/aQute/jars/bnd-0.0.249.LICENSE stage/aQute/jars/bnd-0.0.249.jar
Date Sun, 15 Jun 2008 13:27:26 GMT
On Sun, Jun 15, 2008 at 2:15 PM, Stefano Bagnara <apache@bago.org> wrote:
> Robert Burrell Donkin ha scritto:
>>
>> On Sun, Jun 15, 2008 at 12:52 PM, Stefano Bagnara <apache@bago.org> wrote:
>>>
>>> rdonkin@apache.org ha scritto:
>>>>
>>>> Enable OSGi in Ant build
>>>>
>>>> Modified: james/jsieve/trunk/build.xml
>>>> URL:
>>>>
>>>> http://svn.apache.org/viewvc/james/jsieve/trunk/build.xml?rev=667819&r1=667818&r2=667819&view=diff
>>>>
>>>>
>>>> ==============================================================================
>>>> +              definitions="manve-bundle.bnd"/>
>>>
>>> What is this "definitions" ?
>>> is "manve" a typo for "maven" or what?
>>>
>>> I see a maven-build.bnd in the source tree: should this be a pointer to
>>> that
>>> file?
>>
>> think so but it seemed to work ok so maybe i don't understand the bnd
>> ant tasks correctly (which is very possible). please feel free to jump
>> in and patch.
>
> I don't understand it very much too :-/
>
> Looking at docs it seems definitions should be a folder, so I changed it to
> ".": maybe it looks for *.bnd in that folder and it silently fallback to "."
> when the given "definitions" folder cannot be found.
>
> But I also tried to remove the maven-build.bnd file from the file system and
> the generated jar (and MANIFEST) is identical. I'm a bit lost on this...
>
> Maybe we can remove that bnd file from our source tree?

if it does no good, go ahead. probably needs more fiddling to get it right.

the maven build gives a better manifest anyway. norman's volunteered
to cut jsieve so if he's happy to use maven, i'm not so worried about
a perfect ant build ATM.

- robert

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message