james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefano Bagnara <apa...@bago.org>
Subject Re: [mailets] moving tests for standard mailets from phoenix-deployment
Date Thu, 31 Jul 2008 23:20:58 GMT
Stefano Bagnara ha scritto:
> Robert Burrell Donkin ha scritto:
>> On 7/30/08, Stefano Bagnara <apache@bago.org> wrote:
>>> Ok the mailet project is in good status.
>>>
>>> What is missing is running tests from ant and building the the test-jar.
>>>
>>> server-trunk instead is not working yet.. I thought I could have
>>> finished it today but I have to go now.. I'll complete it tomorrow.
>> Ok
>>
>> Thanks for letting everyone know
> 
> Server-trunk is working fine again (both ant and m2 builds). At the end 
> yesterday I found the needed cycles to complete it and not leave a 
> broken repository ;-)
> 
> I'm not moving some more class from tests.. I moved most of the 
> transport package to the spoolmanager function, but I have an issue with 
> LocalDeliveryTest.
> 
> LocalDeliveryTest depends on
> - MockMailServer
>   - MockMailServer depends on MockUsersRepository.
> - MockUsersRepository
> 
> MockUsersRepository implements user-api interfaces and uses user-library 
> code.
> MockMailServer implements core-library interfaces.
> 
> So I cannot move MockMailServer to a library level because it depends on 
> 2 already existing libraries.
> 
> By consequence I cannot move the LocalDeliveryTest to the spoolmanager 
> function where it belongs.
> 
> How do we solve this?

This was easy once I slept on it. A small refactoring for MockMailServer 
to remove the MockUsersDependency did the trick.

Stefano

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message