james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <server-...@james.apache.org>
Subject [jira] Updated: (MIME4J-5) Mime4j takes really long to parse big messages
Date Wed, 09 Jul 2008 14:39:34 GMT

     [ https://issues.apache.org/jira/browse/MIME4J-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Oleg Kalnichevski updated MIME4J-5:
-----------------------------------

    Attachment: mime4j-4.patch

Fixed parsing of complex multipart entities with embedded messages; minor performance tweaks
(replaced synchronized StringBuffer with unsynchronized CharArrayBuffer; changed MimeEntity
to re-use temp content buffer)

As far as I can tell all major performance bottlenecks have been eliminated and regressions
fixed. I believe the issue can be closed.

One minor performance optimization I can think of would be reusing shiftTable used by the
InputBuffer#indexOf methods but that would come at the expense of breaking the principles
of encapsulation and exposing implementation details to the public API

Robert, you may also want to move some of the new classes from o.a.j.mime4j to some other
packages, o.a.j.mime4j.util for instance)

Oleg

> Mime4j takes really long to parse big messages
> ----------------------------------------------
>
>                 Key: MIME4J-5
>                 URL: https://issues.apache.org/jira/browse/MIME4J-5
>             Project: Mime4j
>          Issue Type: Bug
>    Affects Versions: 0.3
>            Reporter: Norman Maurer
>            Assignee: Robert Burrell Donkin
>             Fix For: 0.4
>
>         Attachments: mime4j-2.patch, mime4j-3.patch, mime4j-4.patch, mime4j.patch
>
>
> From ml:
> Mime4j has general demonstrable performance problems:
> http://buni.org/bugzilla/show_bug.cgi?id=137
> http://blog.buni.org/blog/mbarker/Meldware/2007/01/27/Look-out-Its-behind-you
> I'd suggest a general code review for the "byte at a time + buffered input stream" anti-pattern
> and general refactoring to do things in blocks where possible.
> -Andy

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message