james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefano Bagnara <apa...@bago.org>
Subject Re: getChildLogger (Was: [jira] Commented: (JSIEVE-16) Singletons -> IoC)
Date Wed, 03 Sep 2008 17:49:25 GMT
Robert Burrell Donkin ha scritto:
> On Tue, Sep 2, 2008 at 8:55 AM, Stefano Bagnara <apache@bago.org> wrote:
>> Robert Burrell Donkin ha scritto:
>>> On Mon, Sep 1, 2008 at 2:30 PM, Stefano Bagnara <apache@bago.org> wrote:
>>>> Robert Burrell Donkin ha scritto:
>>>>> On Sun, Aug 31, 2008 at 6:13 PM, Stefano Bagnara <apache@bago.org>
>>>>> wrote:
>>>>>> Robert Burrell Donkin ha scritto:
>>> <snip>
>>>
>>>>>>> i'm not sure it's worthwhile to create yet another logger bridge
in
>>>>>>> this case. injecting a JCL log is probably good enough.
>>>>>> My issue with JCL injecting is that Logger does not have a
>>>>>> getChildLogger.
>>>>> yes - that's probably the biggest mistake we made when creating the
>>>>> API. then again, the JEE specifications weren't broken at that time so
>>>>> it didn't seem necessary to cater for injecting loggers.
>>>> OT: why not to starting a commons-logging 2.0 that has this feature?
>>> 1. ceki already did
>> Do you speak about ILoggerFactory in slf4j or something else?
> 
> slf4j

I've read something, and I think it is a pity that is has been 
implemented as a separated interface.

A ChildGeneratingLogger spi like the LocationAwareLogger would have been 
much better, IMHO.
http://www.slf4j.org/api/org/slf4j/spi/LocationAwareLogger.html

But I admit I may miss something and Ceki arguments are often very 
convincing!

>>> 2. JCL's good enough so nothing else is ever to reach critical mass
>> Joerg Hohwiller crusade to add a new extended interface for the Ioc friendly
>> logger (e.g: IoCLogger) was not so bad.
>> This could have been easy even in a minor release and it could have been
>> added to api only at first.
> 
> there wasn't any realistic way to add it without breaking
> compatibility. we analysed many permutations but in the JCL2.0 was
> never going to fly,
> 
>>> 3. really the JCP should just get ceki to create a decent logging API
>> true, but I don't expect a "java.util.newlogging" ever..
> 
> all it requires is energy
> 
>>> 4. i've wasted too many hundreds of hours on logging already
>> I understood this while looking markmail for this getChildLogger issue!
>> Thank you!
>>
>> Interesting! It's cool to know that someone else see things like me :-)
>>
>> http://markmail.org/message/4hlquicqcyovfv6a
>> http://markmail.org/message/ynsu2uutkh2z7mfp
>>
>> Expecially http://markmail.org/message/3lnqomomugq3xyec
>>
>> I see at the end of 2005 there was a patch to add getChildLogger and a
>> discussion about releasing and then add it, but I didn't found what happened
>> then. I guess it simply died or you found blocking issues... it's a pity.
> 
> it would have required a major version increment. the collections hell
> was bad but JCL would have been much, much worse. better to leave the
> field clear for ceki.

Thank you again for the explanation/revival.

Stefano

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message