james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Markus Wiederkehr" <markus.wiederk...@gmail.com>
Subject Re: [mime4j] Java 5?
Date Sun, 09 Nov 2008 19:34:38 GMT
On Sun, Nov 9, 2008 at 7:52 PM, Oleg Kalnichevski <olegk@apache.org> wrote:
> On Sun, 2008-11-09 at 19:05 +0100, Markus Wiederkehr wrote:
>> On Sun, Nov 9, 2008 at 4:51 PM, Oleg Kalnichevski <olegk@apache.org> wrote:
>> > I am very much in favor of upgrading to Java 1.5 and am prepared to do
>> > all the necessary leg work.
>>
>> As luck would have it I have already done the migration (before you
>> wrote this). It includes generics, enhanced for-loops, override and
>> deprecated annotations and an enum for the mode-constants in
>> MessageUtils. If you want to have it I could send the patch to you, to
>> this mailing list or open an issue and post it there. Please decide.
>>
>> Markus
>>
>
> Opening a JIRA and attaching the patch to it would be the best way to go
> about it.

Done.

Two things I have noticed while writing this patch:

* o.a.j.m.u.StringArrayMap is not used anywhere and could probably be deleted.
* some of the source files use tabs for indentation (package
o.a.j.m.field.address)

Markus

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message