james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Burrell Donkin" <robertburrelldon...@gmail.com>
Subject Re: [mime4j] Remove StringArrayMap?
Date Mon, 01 Dec 2008 13:38:53 GMT
On Mon, Dec 1, 2008 at 1:10 PM, Markus Wiederkehr
<markus.wiederkehr@gmail.com> wrote:
> On Mon, Nov 17, 2008 at 1:23 PM, Markus Wiederkehr
> <markus.wiederkehr@gmail.com> wrote:
>> Does org.apache.james.mime4j.util.StringArrayMap serve any purpose? It
>> does not seem to be used anywhere and in my opinion should be removed
>> or marked as deprecated..
> I have just stumbled upon MIME4J-24. Maybe this class serves a purpose
> after all? I don't know, you have to decide.

At the very least, it needs to be better documented

> If the class should be kept I would at least suggest some refactoring.
> All the methods that return Enumerations should be refactored to
> return Iterators and possibly more like that.

submit a patch ;-)

- robert

To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org

View raw message