james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nor...@apache.org
Subject svn commit: r834137 - in /james/hupa/trunk/client/src/main/java/org/apache/hupa/client: mvp/ widgets/
Date Mon, 09 Nov 2009 16:40:10 GMT
Author: norman
Date: Mon Nov  9 16:39:56 2009
New Revision: 834137

URL: http://svn.apache.org/viewvc?rev=834137&view=rev
Log:
cleanup/javadocs

Added:
    james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/EnableButton.java
      - copied, changed from r831874, james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/MyButton.java
Removed:
    james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/MyButton.java
Modified:
    james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListView.java
    james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendView.java
    james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/HasDialog.java
    james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/Loading.java
    james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/PagingOptions.java

Modified: james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListView.java
URL: http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListView.java?rev=834137&r1=834136&r2=834137&view=diff
==============================================================================
--- james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListView.java
(original)
+++ james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListView.java
Mon Nov  9 16:39:56 2009
@@ -31,7 +31,7 @@
 import org.apache.hupa.client.widgets.ConfirmDialogBox;
 import org.apache.hupa.client.widgets.DragRefetchPagingScrollTable;
 import org.apache.hupa.client.widgets.HasDialog;
-import org.apache.hupa.client.widgets.MyButton;
+import org.apache.hupa.client.widgets.EnableButton;
 import org.apache.hupa.client.widgets.PagingOptions;
 import org.apache.hupa.client.widgets.DragRefetchPagingScrollTable.DragHandlerFactory;
 import org.apache.hupa.shared.data.IMAPFolder;
@@ -94,13 +94,13 @@
     private CachedTableModel<Message> cTableModel;
 
     private FixedWidthGrid dataTable = createDataTable();
-    private MyButton deleteMailButton = new MyButton(constants.deleteMailButton());
+    private EnableButton deleteMailButton = new EnableButton(constants.deleteMailButton());
     private    Button newMailButton = new Button(constants.newMailButton());
     private Button deleteAllMailButton = new Button(constants.deleteAll());
     private ConfirmDialogBox confirmBox = new ConfirmDialogBox();
     private ConfirmDialogBox confirmDeleteAllBox = new ConfirmDialogBox();
-    private MyButton markSeenButton = new MyButton(constants.markSeen());
-    private MyButton markUnSeenButton = new MyButton(constants.markUnseen());
+    private EnableButton markSeenButton = new EnableButton(constants.markSeen());
+    private EnableButton markUnSeenButton = new EnableButton(constants.markUnseen());
 
     private ListBox pageBox = new ListBox();
     private Hyperlink allLink = new Hyperlink(constants.all(),"");    

Modified: james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendView.java
URL: http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendView.java?rev=834137&r1=834136&r2=834137&view=diff
==============================================================================
--- james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendView.java
(original)
+++ james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendView.java
Mon Nov  9 16:39:56 2009
@@ -26,7 +26,7 @@
 
 import org.apache.hupa.client.HupaConstants;
 import org.apache.hupa.client.widgets.Loading;
-import org.apache.hupa.client.widgets.MyButton;
+import org.apache.hupa.client.widgets.EnableButton;
 import org.apache.hupa.widgets.ui.EnableHyperlink;
 import org.apache.hupa.widgets.ui.HasEnable;
 
@@ -62,7 +62,7 @@
     private BaseUploadStatus uploadStatus = new BaseUploadStatus();
     private MultiUploader uploader = new MultiUploader(uploadStatus);
     private TextArea text = new TextArea();
-    private MyButton sendButton = new MyButton(constants.sendButton());
+    private EnableButton sendButton = new EnableButton(constants.sendButton());
     private EnableHyperlink backButton = new EnableHyperlink(constants.backButton(),"");
     private Loading sendProgress = new Loading(true);
 

Copied: james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/EnableButton.java
(from r831874, james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/MyButton.java)
URL: http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/EnableButton.java?p2=james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/EnableButton.java&p1=james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/MyButton.java&r1=831874&r2=834137&rev=834137&view=diff
==============================================================================
--- james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/MyButton.java (original)
+++ james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/EnableButton.java
Mon Nov  9 16:39:56 2009
@@ -22,13 +22,18 @@
 import org.apache.hupa.widgets.ui.HasEnable;
 import org.cobogw.gwt.user.client.ui.Button;
 
-public class MyButton extends Button implements HasEnable{
+/**
+ * Button which supports enabling / disabling
+ * 
+ *
+ */
+public class EnableButton extends Button implements HasEnable{
 
-    public MyButton(String sendButton) {
+    public EnableButton(String sendButton) {
         super(sendButton);
     }
 
-    public MyButton() {
+    public EnableButton() {
         super();
     }
 }

Modified: james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/HasDialog.java
URL: http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/HasDialog.java?rev=834137&r1=834136&r2=834137&view=diff
==============================================================================
--- james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/HasDialog.java (original)
+++ james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/HasDialog.java Mon
Nov  9 16:39:56 2009
@@ -19,8 +19,25 @@
 
 package org.apache.hupa.client.widgets;
 
+/**
+ * Interface which Dialog implementations should implement
+ * 
+ *
+ */
 public interface HasDialog {
+    
+    /**
+     * Show Dialog
+     */
     public void show();
+    
+    /**
+     * Hide Dialog
+     */
     public void hide();
+    
+    /**
+     * Center Dialog and show it
+     */
     public void center();
 }

Modified: james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/Loading.java
URL: http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/Loading.java?rev=834137&r1=834136&r2=834137&view=diff
==============================================================================
--- james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/Loading.java (original)
+++ james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/Loading.java Mon
Nov  9 16:39:56 2009
@@ -29,6 +29,10 @@
 import com.google.gwt.user.client.ui.Label;
 import com.google.gwt.user.client.ui.SimplePanel;
 
+/**
+ * Widget which shows a Loading state
+ *
+ */
 public class Loading extends Composite{
     private HupaConstants constants = GWT.create(HupaConstants.class);
     private SimplePanel sPanel = new SimplePanel();
@@ -44,11 +48,17 @@
         initWidget(sPanel);
     }
     
+    /**
+     * Show the Loading image
+     */
     public void show() {
         sPanel.clear();
         sPanel.add(panel);
     }
     
+    /**
+     * Hde the Loading image
+     */
     public void hide() {
         sPanel.clear();
         sPanel.add(new HTML("&nbsp"));

Modified: james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/PagingOptions.java
URL: http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/PagingOptions.java?rev=834137&r1=834136&r2=834137&view=diff
==============================================================================
--- james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/PagingOptions.java
(original)
+++ james/hupa/trunk/client/src/main/java/org/apache/hupa/client/widgets/PagingOptions.java
Mon Nov  9 16:39:56 2009
@@ -40,6 +40,10 @@
 import com.google.gwt.user.client.ui.Label;
 import com.google.gwt.user.client.ui.SimplePanel;
 
+/**
+ * PagingOptions for using to control the PagingScrollTable
+ *
+ */
 public class PagingOptions extends Composite {
     private HupaConstants constants = GWT.create(HupaConstants.class);
     
@@ -158,7 +162,8 @@
         initWidget(pagingPanel);
     }
     
-    private void loading(boolean isLoading) {
+
+    protected void loading(boolean isLoading) {
         if (isLoading) {
             loading.show();
             panel.setWidget(loading);
@@ -168,7 +173,8 @@
         }
     
     }
-    private void updateControl(int startCount, int endCount, int rows) {
+    
+    protected void updateControl(int startCount, int endCount, int rows) {
         if (rows == TableModel.UNKNOWN_ROW_COUNT) {
             startCount = 0;
             endCount = 0;
@@ -201,23 +207,47 @@
         text.setText(startCount + " - " + endCount + " of " + rows);
 
     }
+    
+    /**
+     * Reset the currentPage to 0 
+     */
     public void reset() {
         currentPage = 0;
         text.setText("0 - 0 of 0");
     }
     
+    /**
+     * Return the Link to navigate to the first page
+     * 
+     * @return firstLink
+     */
     public EnableHyperlink getFirstLink() {
         return firstLink;
     }
     
+    /**
+     * Return the Link to navigate to the previous page
+     * 
+     * @return prevLink
+     */
     public EnableHyperlink getPrevLink() {
         return prevLink;
     }
     
+    /**
+     * Return the Link to navigate to the next page
+     * 
+     * @return nextLink
+     */
     public EnableHyperlink getNextLink() {
         return nextLink;
     }
     
+    /**
+     * Return the Link to navigate to the last page
+     * 
+     * @return lastLink
+     */
     public EnableHyperlink getLastLink() {
         return lastLink;
     }



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message