james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Huff (JIRA)" <server-...@james.apache.org>
Subject [jira] Created: (JAMES-1019) getDomainsInternal in JDBCVirtualUserTable needs reworked
Date Fri, 18 Jun 2010 21:47:23 GMT
getDomainsInternal in JDBCVirtualUserTable needs reworked
---------------------------------------------------------

                 Key: JAMES-1019
                 URL: https://issues.apache.org/jira/browse/JAMES-1019
             Project: JAMES Server
          Issue Type: Bug
          Components: UsersStore & UsersRepository
    Affects Versions: Trunk
            Reporter: Jeff Huff


FindBugs reports the following error in JDBCVirtualUserTable.java


C:/svnpublic/james-server/user-function/src/main/java/org/apache/james/vut/JDBCVirtualUserTable.java:504
Call to equals() comparing different types

Should probably be more like this...


                    String domain = mappingRS.getString(1).toLowerCase();
                    if(domain.equals(WILDCARD) == false && domains.contains(domain)
== false) {
                        domains.add(domain);
                    }


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message