james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Charles <e...@apache.org>
Subject Re: [IMAP] countMailboxesWithName
Date Fri, 25 Jun 2010 03:29:21 GMT
Hi Tim,

Same for the domain creation.
Currently, you may have duplicates in db, and when you list domains, it 
"hides" it via a Set.
A strategy is to check if it already exists before writing it.

So patch it :)
Tks,

Eric


On 06/24/2010 10:41 PM, Tim-Christian Mundt wrote:
> Hi,
>
> in IMAP the method MailboxMapper.countMailboxesWithName(mailboxName) is
> only ever used in StoreMailboxManager.mailboxExists(mailboxName,
> session). There the result is checked for duplicates. Duplicates should
> be detected before writing and not when reading, for some stores (e.g.
> maildir) it is not even possible to have more than one mailbox with the
> same name. So this is superfluous and should should be moved to the
> MailboxMapper.existsMailbox(mailboxName) which can provide a more
> efficient existence test.
>
> I think I proposed that before but can't find to reason why it's not
> there. Thus I thought I'd check back with you before I change it. Any
> objections? Otherwise I'd submit a patch.
>
> Cheers
> Tim
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
>    


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message