james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Aldrich (JIRA)" <j...@apache.org>
Subject [jira] Closed: (JDKIM-21) potential issues?
Date Thu, 16 Sep 2010 22:28:43 GMT

     [ https://issues.apache.org/jira/browse/JDKIM-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ben Aldrich closed JDKIM-21.
----------------------------


Thanks again!

-Ben

> potential issues? 
> ------------------
>
>                 Key: JDKIM-21
>                 URL: https://issues.apache.org/jira/browse/JDKIM-21
>             Project: JAMES jDKIM
>          Issue Type: Question
>          Components: library
>    Affects Versions: 0.2, 1.0
>         Environment: java version "1.6.0_18" ubuntu 10.04
>            Reporter: Ben Aldrich
>            Assignee: Stefano Bagnara
>            Priority: Minor
>             Fix For: 0.2
>
>
> I ran the jdkim library through find bugs and found a few things. Some things i thought
you might be doing because of backwards compatibility. So here is the quick list.
> DKIMVerifier:
> records.size() == 0 instead of records.isEmpty()
> fields.size() == 0 instead of fields.isEmpty()
> use of hashtable (it's deprecated) 
> bodyHashJobs.size() == 0 instead of bodyHashJobs.isEmpty()
> verifiedSignatures.size() == 0 instead of verifiedSignatures.isEmpty()
> DKIMCommon:
> done = new Integer(0) instead of Integer.valueOf(0) *I noticed you have a comment for
this already?
> DNSPublicKeyRecordRetriever:
> use of StringBuffer instead of StringBuilder
> SignatureRecordImpl:
> use of StringBuffer instead of StringBuilder
> TagValue:
> use of StringBuffer instead of StringBuilder

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message