james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Aldrich (JIRA)" <j...@apache.org>
Subject [jira] Updated: (JDKIM-20) jdkim will throw unexpected exceptions
Date Mon, 13 Sep 2010 17:50:33 GMT

     [ https://issues.apache.org/jira/browse/JDKIM-20?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ben Aldrich updated JDKIM-20:
-----------------------------

    Attachment: illegalargumentexception.txt

This is a file in mbox format that causes the illegal argument exception. This file came from
our production mail feed. I will have to dig around a little more to find a mail file that
causes the illegal state exception. 

> jdkim will throw unexpected exceptions
> --------------------------------------
>
>                 Key: JDKIM-20
>                 URL: https://issues.apache.org/jira/browse/JDKIM-20
>             Project: JAMES jDKIM
>          Issue Type: Bug
>          Components: library
>    Affects Versions: 0.2, 1.0
>         Environment: java version "1.6.0_18" ubuntu 10.04
>            Reporter: Ben Aldrich
>         Attachments: illegalargumentexception.txt
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> when calling validate I am seeing IllegalStateExceptions and IllegalArgumentException.

> It looks like we just need to catch these exceptions in the DKIMVerifier.java
> more specifically, in the verify method we need to add this around line 270 :
>                     } catch (IllegalArgumentException e) {
>                         throw new PermFailException(e.getMessage());
> and we should also add this in the signatureVerify method:
>         try {
>           signature.initVerify(key.getPublicKey());
>         } catch (IllegalStateException e) {
>             throw new PermFailException(e.getMessage());
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message