james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Charles <e...@apache.org>
Subject Re: svn commit: r1052881 - in /james/server/trunk/container-spring/src/main/config/james/context: james-mailbox-jcr-context.xml james-mailbox-jpa-context.xml james-mailbox-maildir-context.xml james-mailbox-memory-context.xml
Date Fri, 31 Dec 2010 15:25:15 GMT
Yes, makes sense.
Eric

On 31/12/2010 15:37, Norman Maurer wrote:
> Well I think an init() and destroy() method does not really belong to
> the interface.. Its more implementation generic..
>
> Bye,
> Norman
>
>
> 2010/12/26 Eric Charles<eric@apache.org>:
>> Hi Norman,
>>
>> Any particular reason to add init() on StoreMailboxManager abstract class
>> and not on MailboxManager interface ?
>> Also, if we have init(), what about close() ?
>>
>> Tks,
>>
>> Eric
>>
>>
>> On 26/12/2010 13:00, norman@apache.org wrote:
>>> Author: norman
>>> Date: Sun Dec 26 12:00:30 2010
>>> New Revision: 1052881
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1052881&view=rev
>>> Log:
>>> Adjust spring xml to call new init() method of StoreMailboxManager
>>> implementations
>>>
>>> Modified:
>>>
>>> james/server/trunk/container-spring/src/main/config/james/context/james-mailbox-jcr-context.xml
>>>
>>> james/server/trunk/container-spring/src/main/config/james/context/james-mailbox-jpa-context.xml
>>>
>>> james/server/trunk/container-spring/src/main/config/james/context/james-mailbox-maildir-context.xml
>>>
>>> james/server/trunk/container-spring/src/main/config/james/context/james-mailbox-memory-context.xml
>>>
>>> Modified:
>>> james/server/trunk/container-spring/src/main/config/james/context/james-mailbox-jcr-context.xml
>>> URL:
>>> http://svn.apache.org/viewvc/james/server/trunk/container-spring/src/main/config/james/context/james-mailbox-jcr-context.xml?rev=1052881&r1=1052880&r2=1052881&view=diff
>>>
>>> ==============================================================================
>>> ---
>>> james/server/trunk/container-spring/src/main/config/james/context/james-mailbox-jcr-context.xml
>>> (original)
>>> +++
>>> james/server/trunk/container-spring/src/main/config/james/context/james-mailbox-jcr-context.xml
>>> Sun Dec 26 12:00:30 2010
>>> @@ -27,7 +27,7 @@
>>>         Mailbox JCR
>>>        -->
>>>
>>> -<bean id="jcr-mailboxmanager"
>>> class="org.apache.james.mailbox.jcr.JCRMailboxManager">
>>> +<bean id="jcr-mailboxmanager"
>>> class="org.apache.james.mailbox.jcr.JCRMailboxManager" init-method="init">
>>>           <constructor-arg index="0" ref="jcr-sessionMapperFactory"/>
>>>           <constructor-arg index="1" ref="authenticator"/>
>>>           <constructor-arg index="2" ref="jcr-uidProvider"/>
>>>
>>> Modified:
>>> james/server/trunk/container-spring/src/main/config/james/context/james-mailbox-jpa-context.xml
>>> URL:
>>> http://svn.apache.org/viewvc/james/server/trunk/container-spring/src/main/config/james/context/james-mailbox-jpa-context.xml?rev=1052881&r1=1052880&r2=1052881&view=diff
>>>
>>> ==============================================================================
>>> ---
>>> james/server/trunk/container-spring/src/main/config/james/context/james-mailbox-jpa-context.xml
>>> (original)
>>> +++
>>> james/server/trunk/container-spring/src/main/config/james/context/james-mailbox-jpa-context.xml
>>> Sun Dec 26 12:00:30 2010
>>> @@ -28,7 +28,7 @@
>>>        -->
>>>
>>>       <bean
>>> class="org.springframework.orm.jpa.support.PersistenceAnnotationBeanPostProcessor"/>
>>> -<bean id="jpa-mailboxmanager"
>>> class="org.apache.james.mailbox.jpa.openjpa.OpenJPAMailboxManager">
>>> +<bean id="jpa-mailboxmanager"
>>> class="org.apache.james.mailbox.jpa.openjpa.OpenJPAMailboxManager"
>>> init-method="init">
>>>           <constructor-arg index="0" ref="jpa-sessionMapperFactory"/>
>>>           <constructor-arg index="1" ref="authenticator"/>
>>>           <constructor-arg index="2" ref="jpa-uidProvider"/>
>>>
>>> Modified:
>>> james/server/trunk/container-spring/src/main/config/james/context/james-mailbox-maildir-context.xml
>>> URL:
>>> http://svn.apache.org/viewvc/james/server/trunk/container-spring/src/main/config/james/context/james-mailbox-maildir-context.xml?rev=1052881&r1=1052880&r2=1052881&view=diff
>>>
>>> ==============================================================================
>>> ---
>>> james/server/trunk/container-spring/src/main/config/james/context/james-mailbox-maildir-context.xml
>>> (original)
>>> +++
>>> james/server/trunk/container-spring/src/main/config/james/context/james-mailbox-maildir-context.xml
>>> Sun Dec 26 12:00:30 2010
>>> @@ -28,7 +28,7 @@
>>>        -->
>>>       <!-- WARNING: Maildir does only work on UNIX like operation systems
>>> -->
>>>
>>> -<bean id="maildir-mailboxmanager"
>>> class="org.apache.james.mailbox.maildir.MaildirMailboxManager">
>>> +<bean id="maildir-mailboxmanager"
>>> class="org.apache.james.mailbox.maildir.MaildirMailboxManager"
>>> init-method="init">
>>>           <constructor-arg index="0" ref="maildir-sessionMapperFactory"/>
>>>           <constructor-arg index="1" ref="authenticator"/>
>>>           <constructor-arg index="2" ref="maildir-uidProvider"/>
>>>
>>> Modified:
>>> james/server/trunk/container-spring/src/main/config/james/context/james-mailbox-memory-context.xml
>>> URL:
>>> http://svn.apache.org/viewvc/james/server/trunk/container-spring/src/main/config/james/context/james-mailbox-memory-context.xml?rev=1052881&r1=1052880&r2=1052881&view=diff
>>>
>>> ==============================================================================
>>> ---
>>> james/server/trunk/container-spring/src/main/config/james/context/james-mailbox-memory-context.xml
>>> (original)
>>> +++
>>> james/server/trunk/container-spring/src/main/config/james/context/james-mailbox-memory-context.xml
>>> Sun Dec 26 12:00:30 2010
>>> @@ -29,7 +29,7 @@
>>>       <!-- WARNING: Memory does not persist the mailbox. -->
>>>       <!--          Information will be lost after server restart. -->
>>>
>>> -<bean id="memory-mailboxmanager"
>>> class="org.apache.james.mailbox.inmemory.InMemoryMailboxManager">
>>> +<bean id="memory-mailboxmanager"
>>> class="org.apache.james.mailbox.inmemory.InMemoryMailboxManager"
>>> init-method="init">
>>>           <constructor-arg index="0" ref="memory-sessionMapperFactory"/>
>>>           <constructor-arg index="1" ref="authenticator"/>
>>>           <constructor-arg index="2" ref="memory-uidProvider"/>
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>> For additional commands, e-mail: server-dev-help@james.apache.org
>>
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message