james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Felix Knecht <fel...@apache.org>
Subject Re: Reporting / Code review
Date Wed, 02 Mar 2011 17:27:50 GMT
On 02/25/2011 12:04 PM, Eric Charles wrote:
> Impressive result
> [2] and [3]: we've got some work to have nicer report.
> [1] seems like jquery tabs are broken (however js is available
> http://people.apache.org/~felixk/james/server/trunk/js/jquery/js/jquery-ui-1.8.5.custom.min.js)

It's not a jQuery problem. But there are more than just 1 problem which 
didn't occur up to now by change or by less restrictive parsers or ?

- If in a xdoc document you have "<head><script>" the <script> tag isn't

copied over by the site.vm template. I haven't found where to put it in 
Jira, so here's the patch [1]

- Another problem I alread stated in other project (apache-cocoon) is, 
that the body part of the <script> tag isn't really taken. That's why 
it's saver to put the script in it's own file and reference it via the 
src attribute.

Regards
Felix

[1]
Index: maven-skin/src/main/resources/META-INF/maven/site.vm
===================================================================
--- maven-skin/src/main/resources/META-INF/maven/site.vm 
(revision 1074121)
+++ maven-skin/src/main/resources/META-INF/maven/site.vm        (working 
copy)
@@ -296,6 +296,7 @@
          #end
        #end
      #end
+    $headContent
    </head>
    <body class="composite">
      <div id="banner">

>
> :)
> Tks,
> - Eric
>
> On 25/02/2011 08:41, Felix Knecht wrote:
>> Hi all
>>
>> I generated the site with additional report for the server project and
>> put it to [1]. Maybe your interested in. AFAIK such a site can also be
>> generated by hudson CI on a e.g. daily/weekly base for code review by
>> envoking 'mvn site'. For better layout reason I shortened the module
>> names by stripping the 'Apache James Server'.
>>
>> Apart of the pmd report [2] already existing also the findbugs report
>> [3] (can't be aggregated, so drill down by clicking several time on
>> the "FindBugs Report Summary" link to see module specific report)
>> maybe helpful.
>>
>> Kind regards
>> Felix
>>
>> [1] http://people.apache.org/~felixk/james/server/trunk/index.html
>> [2] http://people.apache.org/~felixk/james/server/trunk/pmd.html
>> [3]
>> http://people.apache.org/~felixk/james/server/trunk/dashboard-report.html#findbugs
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>> For additional commands, e-mail: server-dev-help@james.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message