james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Felix Knecht (JIRA)" <server-...@james.apache.org>
Subject [jira] Updated: (JAMES-1041) Review each pom (in server and imap) for unused declared dependency and maven 3 compatibility
Date Wed, 02 Mar 2011 11:41:36 GMT

     [ https://issues.apache.org/jira/browse/JAMES-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Felix Knecht updated JAMES-1041:
--------------------------------

    Attachment: imap-poms-m3.patch

Applied patch will prerequisite maven version >= 3.0.2.

NOTE:
In Hudson CI the configuration needs probably to be changed to use at least maven-3.0.2 (I
can't see the configuration, but the log says "Found mavenVersion 2.0.9")!

- I tried to remove dependencies in module poms where they are already defined via transitivity.
- <profiles> section in message/processor modules can also be remove due to inheritence.
- Add a <pluginManagement> section for the used plugins
- Updated the plugins to the latest version

It builts for me using Apache Maven 3.0.2 (r1056850; 2011-01-09 01:58:10+0100).

I found out that mvn dependency:analyze may give false positives. E.g. for the processor module.
Neither is *-imap-message an unused dependency (it doesn't compiles without) nor is *-mailbox-api
not declared (declared via inherited dependencyManagement).

<snip>
[INFO] --- maven-dependency-plugin:2.1:analyze (default-cli) @ apache-james-imap-processor
---
[WARNING] Used undeclared dependencies found:
[WARNING]    junit:junit-dep:jar:4.4:test
[WARNING]    javax.mail:mail:jar:1.4.3:compile
[WARNING]    org.apache.james:apache-james-mailbox-api:jar:0.2-M2-SNAPSHOT:compile
[WARNING]    org.slf4j:slf4j-api:jar:1.6.1:compile
[WARNING]    org.hamcrest:hamcrest-core:jar:1.1:test
[WARNING] Unused declared dependencies found:
[WARNING]    org.apache.james:apache-james-imap-message:jar:0.2-M2-SNAPSHOT:compile
</snip>

The profile -Pgeronimo doesn't works because of missing dependencies. Changing following properties
in the profile will at least work for building.

<version.javax.mail>1.4.3</version.javax.mail>
<version.activation>1.1.1</version.activation>


BTW
The parent module can be remove from svn IMO, but I can create a diff for that somehow ...

> Review each pom (in server and imap) for unused declared dependency and maven 3 compatibility
> ---------------------------------------------------------------------------------------------
>
>                 Key: JAMES-1041
>                 URL: https://issues.apache.org/jira/browse/JAMES-1041
>             Project: JAMES Server
>          Issue Type: Improvement
>            Reporter: Eric Charles
>             Fix For: 3.0
>
>         Attachments: imap-poms-m3.patch
>
>
> If you run mvn dependency:analyze in pop3server for example, you will have:
> [WARNING] Unused declared dependencies found:
> [WARNING]    org.apache.james:james-server-user-library:jar:3.0-SNAPSHOT:runtime
> [WARNING]    org.apache.james:james-server-core-function:jar:3.0-SNAPSHOT:runtime
> Running pom with maven 3 also shows:
> [WARNING] The expression ${pom.version} is deprecated. Please use ${project.version}
instead. @
> We must correct this for all server and imap projects (pom.xml).

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message