james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nor...@apache.org
Subject svn commit: r1152175 - /james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/fetch/EnvelopeBuilder.java
Date Fri, 29 Jul 2011 11:40:35 GMT
Author: norman
Date: Fri Jul 29 11:40:34 2011
New Revision: 1152175

URL: http://svn.apache.org/viewvc?rev=1152175&view=rev
Log:
Better handling of unfold whcih includes the replacement of tabs with spaces. See IMAP-327

Modified:
    james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/fetch/EnvelopeBuilder.java

Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/fetch/EnvelopeBuilder.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/fetch/EnvelopeBuilder.java?rev=1152175&r1=1152174&r2=1152175&view=diff
==============================================================================
--- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/fetch/EnvelopeBuilder.java
(original)
+++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/fetch/EnvelopeBuilder.java
Fri Jul 29 11:40:34 2011
@@ -25,6 +25,8 @@ package org.apache.james.imap.processor.
 import java.util.ArrayList;
 import java.util.List;
 
+import javax.mail.internet.MimeUtility;
+
 import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.message.response.FetchResponse;
 import org.apache.james.mailbox.Headers;
@@ -76,7 +78,13 @@ public final class EnvelopeBuilder {
 
                 // ENVELOPE header values must be unfolded
                 // See IMAP-269
-                result = MimeUtil.unfold(value);
+            	//
+            	//
+            	// IMAP-Servers are advised to also replace tabs with single spaces while doing
the unfolding. This is what javamails
+            	// unfold does. mime4j's unfold does strictly follow the rfc and so preserve
them
+            	// 
+            	// See IMAP-327 and https://mailman2.u.washington.edu/mailman/htdig/imap-protocol/2010-July/001271.html
+                result = MimeUtility.unfold(value);
 
             }
         }
@@ -112,7 +120,12 @@ public final class EnvelopeBuilder {
 
             // We need to unfold the header line.
             // See https://issues.apache.org/jira/browse/IMAP-154
-            String value = MimeUtil.unfold(header.getValue());
+        	//
+        	// IMAP-Servers are advised to also replace tabs with single spaces while doing
the unfolding. This is what javamails
+        	// unfold does. mime4j's unfold does strictly follow the rfc and so preserve them
+        	// 
+        	// See IMAP-327 and https://mailman2.u.washington.edu/mailman/htdig/imap-protocol/2010-July/001271.html
+            String value = MimeUtility.unfold(header.getValue());
 
             if ("".equals(value.trim())) {
                 results = null;



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message