james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Charles <e...@apache.org>
Subject Re: svn commit: r1147372 - /james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/AbstractMailboxManagerTest.java
Date Wed, 27 Jul 2011 07:17:35 GMT
If we apply this logic to all mailboxes, we will have remaining empty 
folders. This is confusing and will impact some logic in other methods, 
such as list().

Maybe we could apply this logic only for INBOX path.

WDYT?

On 26/07/11 20:02, Norman Maurer wrote:
> I think we should just remove the cur/new/tmp folders and the metadata
> when using maildir.
>
> Bye,
> Norman
>
>
> 2011/7/26 Eric Charles<eric@apache.org>:
>> Hi Norman,
>>
>> Thx for the confirmation.
>> I've reactivated the test in trunk, but it break the maildir test.
>>
>> Maildir is special because 'INBOX' is a folder (with its cur/ new/ tmp/) and
>> any other folders (.INBOX.SUB1, .Archives,...) reside within that 'INBOX'
>> folder.  So if we leave MaildirMailboxMapper.delete as now, and invoke it
>> with mailbox=INBOX, it will simply remove all the folders, and this is not
>> what we want.
>>
>> Other mailbox implementations don't have that.
>>
>> So we could test beforehand for any subfolders others that cur/, new/, tmp/
>> and throwing a MailboxException if we find some ('You must delete all INBOX
>> subfolders to delete INBOX on Maildir implementation').
>>
>> If this sounds good, I will implement it.
>>
>> Thx.
>>
>> On 17/07/11 11:17, Norman Maurer wrote:
>>>
>>> If you delete a Mailbox with sub Mailboxen, its necessary that the
>>> submailboxes don't get deleted.
>>>
>>>
>>> Bye
>>> Norman
>>>
>>>
>>> Am Samstag, 16. Juli 2011 schrieb Eric Charles<eric@apache.org>:
>>>>
>>>> The question is "what do we do when we delete a mailbox with sub
>>>> mailboxes ?"
>>>>
>>>> For now, we allow this (I didn't check in RFC if this is allowed).
>>>>
>>>> With the merge of mailboxmanager tests, it succeeds with jpa/jcr, but
>>>> fails with maildir (logical!).
>>>>
>>>> Any hint?
>>>>
>>>> On 16/07/11 09:37, eric@apache.org wrote:
>>>>
>>>> Author: eric
>>>> Date: Sat Jul 16 07:37:48 2011
>>>> New Revision: 1147372
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1147372&view=rev
>>>> Log:
>>>> Temporary comment to avoid maildir test failure (MAILBOX-73)
>>>>
>>>> Modified:
>>>>
>>>>   james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/AbstractMailboxManagerTest.java
>>>>
>>>> Modified:
>>>> james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/AbstractMailboxManagerTest.java
>>>> URL:
>>>> http://svn.apache.org/viewvc/james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/AbstractMailboxManagerTest.java?rev=1147372&r1=1147371&r2=1147372&view=diff
>>>>
>>>> ==============================================================================
>>>> ---
>>>> james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/AbstractMailboxManagerTest.java
>>>> (original)
>>>> +++
>>>> james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/AbstractMailboxManagerTest.java
>>>> Sat Jul 16 07:37:48 2011
>>>> @@ -76,10 +76,13 @@ public abstract class AbstractMailboxMan
>>>>
>>>>            getMailboxManager().deleteMailbox(inbox, session);
>>>>            Assert.assertFalse(getMailboxManager().mailboxExists(inbox,
>>>> session));
>>>> -
>>>>   Assert.assertTrue(getMailboxManager().mailboxExists(inboxSubMailbox,
>>>> session));
>>>>
>>>> -        getMailboxManager().deleteMailbox(inboxSubMailbox, session);
>>>> -
>>>>   Assert.assertFalse(getMailboxManager().mailboxExists(inboxSubMailbox,
>>>> session));
>>>> +        // TODO Temporary commented to avoid maildir test failure
>>>> +
>>>> +//
>>>>   Assert.assertTrue(getMailboxManager().mailboxExists(inboxSubMailbox,
>>>> session));
>>>> +
>>>> +//        getMailboxManager().deleteMailbox(inboxSubMailbox, session);
>>>> +//
>>>>   Assert.assertFalse(getMailboxManager().mailboxExists(inboxSubMailbox,
>>>> session));
>>>>
>>>>            getMailboxManager().logout(session, false);
>>>>            getMailboxManager().endProcessingRequest(session);
>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Eric Charles
>>>> http://about.echarles.net
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>
>>
>>
>> --
>> Eric Charles
>> http://about.echarles.net
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>> For additional commands, e-mail: server-dev-help@james.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>


-- 
Eric Charles
http://about.echarles.net

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message