james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Norman Maurer <norman.mau...@googlemail.com>
Subject Re: ACL Support - cont. from server-user
Date Thu, 26 Jan 2012 16:05:11 GMT
Hi,

sorry for the delay.. I will try to review it this evening...


Thanks,
Norman


2012/1/23 Jochen Gazda <gazdahimself@gmail.com>:
> Norman,
>
> I have created https://issues.apache.org/jira/browse/IMAP-351 on 2012-01-18.
> When may I expect that it will be reviewed?
>
> Best,
>
> Gazda
>
> On Wed, Jan 18, 2012 at 2:29 PM, Norman Maurer
> <norman.maurer@googlemail.com> wrote:
>> Wow....
>>
>> very nice work. I would be more then happy to include it into our
>> code-base. Please open a jira and attach the patch there (don't forget
>> to "check" the ASL2 box). Once its there I will pull the changes in.
>>
>> Thanks,
>> Norman
>>
>>
>> 2012/1/17 Jochen Gazda <gazdahimself@gmail.com>:
>>> Gentlemen,
>>>
>>> could please somebody have a look at the attached patch?
>>> It should be applied against "current" directory. I hope have created
>>> it properly. I have never done it before.
>>>
>>> The patch adds very basic support for GETACL command. A small javamail
>>> based demo program is also attached. "user1@dom1.com" with password
>>> "1234" needs to be created before ImapGetACLTest is run.
>>>
>>> Within my workspace the following tests failed or were skipped for
>>> taking too long to finish, whereby I cannot say if it was due to my
>>> changes:
>>> james-server-smtpserver
>>> apache-james-mailbox-hbase
>>> james-server-queue-activemq
>>>
>>> What needs to be done:
>>>
>>> (1) I have put some FIXMEs and TODOs in the patch where somebody
>>> experienced should please have a look.
>>>
>>> (2) ACL getter and setter stubs should be filled in Mailbox
>>> implementations. New tests should be added for those getters and
>>> setters.
>>> Due to the fact that there is no ACL persistence support in the
>>> mailbox implementations, the only ACLs that are effective at the
>>> moment are the global ACLs in
>>> org.apache.james.mailbox.UnionMailboxACLResolver. The default values
>>> for these global ACLs are: (a) full rights for mailbox owner if the
>>> mailbox owner is a user and (b) full except for a (administration)
>>> rights if the mailbox is a group. I guess this is roughly how it
>>> worked before my patch.
>>>
>>> (3) Mapping of ACL Rights to READ-WRITE and READ-ONLY Response Codes,
>>> see RFC 4314 section 5.2.
>>>
>>> (4) Enforce rights required to perform different IMAP4rev1 Commands in
>>> IMAP processors, see RFC 4314 section 4. Write tests.
>>>
>>> (5) MailboxACLUpdated event should be fired and litstened to.
>>>
>>> Best,
>>>
>>> Gazda
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>> For additional commands, e-mail: server-dev-help@james.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message