james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Charles (JIRA)" <server-...@james.apache.org>
Subject [jira] [Commented] (JAMES-1441) Un-staticize the org.apache.james.mailbox.store.search.MessageSearches
Date Tue, 04 Dec 2012 12:41:00 GMT

    [ https://issues.apache.org/jira/browse/JAMES-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509707#comment-13509707
] 

Eric Charles commented on JAMES-1441:
-------------------------------------

Why do you synchronize to create the uids? If you expect an instance of this class to be used
by multiple threads, it will fail on the iteration...
I suppose going from protected to private is to allow you to extend?
You can also define the 2 public isMatch methods to protected

Thx, Eric
                
> Un-staticize the org.apache.james.mailbox.store.search.MessageSearches
> ----------------------------------------------------------------------
>
>                 Key: JAMES-1441
>                 URL: https://issues.apache.org/jira/browse/JAMES-1441
>             Project: James Server
>          Issue Type: Improvement
>          Components: MailStore & MailRepository
>    Affects Versions: Trunk
>         Environment: all
>            Reporter: Andrzej Rusin
>            Priority: Trivial
>         Attachments: JAMES-1441.patch
>
>
> To allow some overriding, and also make it more elegant, the following would be nice:
> A convert the static methods to non-static,
> B convert certain methods from private to protected,
> C remove the main processing from the constructor (necessary for A, and also a good practice)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message