james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Charles (JIRA)" <server-...@james.apache.org>
Subject [jira] [Commented] (JAMES-1463) Issues in FileMailQueue
Date Thu, 03 Jan 2013 15:08:12 GMT

    [ https://issues.apache.org/jira/browse/JAMES-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542969#comment-13542969
] 

Eric Charles commented on JAMES-1463:
-------------------------------------

Eike, We don't have unit tests for now, so we can only base our selves on code reading or
implementation using.
I don't use FileMailQueue, so I can only say that your both points sound logical based on
code reading.
I will commit your patch.

                
> Issues in FileMailQueue
> -----------------------
>
>                 Key: JAMES-1463
>                 URL: https://issues.apache.org/jira/browse/JAMES-1463
>             Project: James Server
>          Issue Type: Bug
>          Components: Queue
>            Reporter: Eike Kettner
>         Attachments: james-1463.patch
>
>
> I found some issues in FileMailQueue. In JAMES-1429 the problem in the `init()` method
was solved. I think the remaining problems described there could be related to the first of
these two:
> * in `enQueue()`, the NEXT_DELIVERY date is set into the mail _after_ it has already
been written to disk. So after a restart, the mails are put into the queue without taking
the NEXT_DELIVERY into account. This would result in delivering them immediately, if I understand
correctly.
> * in `deQueue()` l.289, the file item is deleted, but the `keyMappings` cache is not
updated. This breaks the management methods (clear/flush/browse) and the cache will grow infinitely.
> I'll attach a patch for these two.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message