james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrzej Rusin (JIRA)" <server-...@james.apache.org>
Subject [jira] [Commented] (JAMES-1494) org.apache.james.smtpserver.CoreCmdHandlerLoader does not register org.apache.james.protocols.smtp.core.UnknownCmdHandler
Date Wed, 27 Mar 2013 21:29:16 GMT

    [ https://issues.apache.org/jira/browse/JAMES-1494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615775#comment-13615775
] 

Andrzej Rusin commented on JAMES-1494:
--------------------------------------

Eric,
you are right about adding these two lines - it works.(kind of).- UnknownCmdHandler gets properly
registered, no more NPE.

The next problem is that org.apache.james.protocols.smtp.core.fastfail.MaxUnknownCmdHandler
can not be properly configured (it allows ZERO unknown commands now), as it does not implement
InitializingLifecycleAwareProtocolHandler.

Is it a matter of creating org.apache.james.smtpserver.fastfail.MaxUnknownCmdHandler that
extends org.apache.james.protocols.smtp.core.fastfail.MaxUnknownCmdHandler and implements
InitializingLifecycleAwareProtocolHandler so it can be configured properly? Is it the corrrect
approach?
                
> org.apache.james.smtpserver.CoreCmdHandlerLoader does not register org.apache.james.protocols.smtp.core.UnknownCmdHandler
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JAMES-1494
>                 URL: https://issues.apache.org/jira/browse/JAMES-1494
>             Project: James Server
>          Issue Type: Bug
>          Components: SMTPServer
>    Affects Versions: Trunk
>            Reporter: Andrzej Rusin
>
> It results in unknown commands getting message:
> 451 Unable to process request
> and NPE:
> DEBUG 15:07:23,602 | james.smtpserver | Id='1219837423' User='' org.apache.james.protocols.api.handler.CommandDispatcher
received: SA
> DEBUG 15:07:23,602 | james.smtpserver | Id='1219837423' User='' Lookup command handler
for command: SA
> DEBUG 15:07:23,603 | james.smtpserver | Id='1219837423' User='' Unable to parse request
> java.lang.NullPointerException
>         at org.apache.james.protocols.api.handler.CommandDispatcher.dispatchCommandHandlers(CommandDispatcher.java:170)
>         at org.apache.james.protocols.api.handler.CommandDispatcher.onLine(CommandDispatcher.java:147)
>         at org.apache.james.protocols.netty.BasicChannelUpstreamHandler.messageReceived(BasicChannelUpstreamHandler.java:147)
>         at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:75)
>         at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:558)
>         at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:777)
>         at org.jboss.netty.channel.SimpleChannelUpstreamHandler.messageReceived(SimpleChannelUpstreamHandler.java:129)
>         at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:75)
>         at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:558)
>         at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:777)
>         at org.jboss.netty.handler.execution.ChannelUpstreamEventRunnable.run(ChannelUpstreamEventRunnable.java:44)
>         at org.jboss.netty.handler.execution.OrderedMemoryAwareThreadPoolExecutor$ChildExecutor.run(OrderedMemoryAwareThreadPoolExecutor.java:312)
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
>         at java.lang.Thread.run(Thread.java:722)
> and addtionally, the UnknownHooks do not fire, hence org.apache.james.protocols.smtp.core.fastfail.MaxUnknownCmdHandler
has no chance to work.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message