james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Munn (JIRA)" <server-...@james.apache.org>
Subject [jira] [Comment Edited] (JAMES-1568) Incorrect reporting of sending SMTP server hostname to receiving SMTP server
Date Thu, 05 Mar 2015 09:35:38 GMT

    [ https://issues.apache.org/jira/browse/JAMES-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348477#comment-14348477
] 

Robert Munn edited comment on JAMES-1568 at 3/5/15 9:34 AM:
------------------------------------------------------------

Patch file for solution follows:

# Eclipse Workspace Patch 1.0
#P james-server
Index: mailet/mailets/src/main/java/org/apache/james/transport/mailets/RemoteDelivery.java
===================================================================
--- mailet/mailets/src/main/java/org/apache/james/transport/mailets/RemoteDelivery.java	(revision
1634685)
+++ mailet/mailets/src/main/java/org/apache/james/transport/mailets/RemoteDelivery.java	(working
copy)
@@ -56,6 +56,7 @@
 import javax.mail.internet.MimePart;
 import javax.mail.internet.ParseException;
 
+import org.apache.geronimo.javamail.transport.smtp.SMTPTransport;
 import org.apache.james.dnsservice.api.DNSService;
 import org.apache.james.dnsservice.api.TemporaryResolutionException;
 import org.apache.james.dnsservice.library.MXHostAddressIterator;
@@ -957,9 +958,10 @@
                     // "mail.smtp.dsn.notify" //default to nothing...appended as
                     // NOTIFY= after RCPT TO line.
 
-                    Transport transport = null;
+                    SMTPTransport transport = null;
                     try {
-                        transport = session.getTransport(outgoingMailServer);
+                        transport =  (SMTPTransport) session.getTransport(outgoingMailServer);
+                        transport.setLocalHost( props.getProperty("mail.smtp.localhost",
heloName) );
                         try {
                             if (authUser != null) {
                                 transport.connect(outgoingMailServer.getHostName(), authUser,
authPass);



was (Author: robertdmunn):
Patch file for solution follows:

### Eclipse Workspace Patch 1.0
#P james-server
Index: mailet/mailets/src/main/java/org/apache/james/transport/mailets/RemoteDelivery.java
===================================================================
--- mailet/mailets/src/main/java/org/apache/james/transport/mailets/RemoteDelivery.java	(revision
1634685)
+++ mailet/mailets/src/main/java/org/apache/james/transport/mailets/RemoteDelivery.java	(working
copy)
@@ -56,6 +56,7 @@
 import javax.mail.internet.MimePart;
 import javax.mail.internet.ParseException;
 
+import org.apache.geronimo.javamail.transport.smtp.SMTPTransport;
 import org.apache.james.dnsservice.api.DNSService;
 import org.apache.james.dnsservice.api.TemporaryResolutionException;
 import org.apache.james.dnsservice.library.MXHostAddressIterator;
@@ -957,9 +958,10 @@
                     // "mail.smtp.dsn.notify" //default to nothing...appended as
                     // NOTIFY= after RCPT TO line.
 
-                    Transport transport = null;
+                    SMTPTransport transport = null;
                     try {
-                        transport = session.getTransport(outgoingMailServer);
+                        transport =  (SMTPTransport) session.getTransport(outgoingMailServer);
+                        transport.setLocalHost( props.getProperty("mail.smtp.localhost",
heloName) );
                         try {
                             if (authUser != null) {
                                 transport.connect(outgoingMailServer.getHostName(), authUser,
authPass);


> Incorrect reporting of sending SMTP server hostname to receiving SMTP server
> ----------------------------------------------------------------------------
>
>                 Key: JAMES-1568
>                 URL: https://issues.apache.org/jira/browse/JAMES-1568
>             Project: James Server
>          Issue Type: Bug
>         Environment: issue is not platform dependent.
>            Reporter: Robert Munn
>
> A bug reported in Apache James mail server was causing the sender smtp server to be incorrectly
reported to the receiving SMTP server. With help from the reporter, I fixed the bug and have
made a patch for it.
> If you are running James v 3 and want the sender hostname to report correctly, apply
the remotedelivery patch and update your conf/mailetcontainer.xml (or .conf for pre-beta 5)
file. Under the RemoteDelivery mailet, uncomment the following line:
> <!-- Set the HELO/EHLO name to use when connectiong to remote SMTP-Server -->
> <mail.smtp.localhost>hostname</mail.smtp.localhost>
> and set hostname to the mx name of your mail server.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message