james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tellier Benoit (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAILBOX-11) MailboxQuery ignore namespace
Date Wed, 03 Jun 2015 09:38:50 GMT

    [ https://issues.apache.org/jira/browse/MAILBOX-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14570541#comment-14570541
] 

Tellier Benoit commented on MAILBOX-11:
---------------------------------------

I think you made a mistake. File that were not commited are :

 create mode 100644 memory/src/test/java/org/apache/james/mailbox/inmemory/InMemoryMailboxMapperTest.java
 create mode 100644 store/src/test/java/org/apache/james/mailbox/store/StoreMailboxManagerTest.java

File you commited are :

Added:
    james/mailbox/trunk/memory/src/test/java/org/apache/james/mailbox/inmemory/mail/
    james/mailbox/trunk/store/src/test/java/org/apache/james/mailbox/store/StoreMailboxManager.java

I can not build on trunk because StoreMailboxManager is duplicated in a package, and there
is still no tests for both InMemoryMailboxMapper and for StoreMailboxManager.

Maybe things can be easier for you if we uses our Github integration tool. Do you want us
to open the PR on Github corresponding to our uploaded awaiting patchs ?

There is several advantages for you :
 - It preserve our Git history.
 - You can do the review on GitHub
 - Once done, you can't forget files, you just need to run one command.

Regards,

Benoit

> MailboxQuery ignore namespace
> -----------------------------
>
>                 Key: MAILBOX-11
>                 URL: https://issues.apache.org/jira/browse/MAILBOX-11
>             Project: James Mailbox
>          Issue Type: Bug
>         Environment: Linux, JDK 1.6
>            Reporter: Fran├žois-Denis Gonthier
>            Assignee: Eric Charles
>             Fix For: 0.6
>
>         Attachments: 0001-MAILBOX-11-Add-filters-on-namespace-and-user-for-sea.patch
>
>
> MailboxQuery doesn't pay any attention to namespace of the mailbox it is based on. For
example, Mozilla Thunderbird might to mailbox search with expressions like #private.%. That
expression is passed directly to the isExpressionMatch method of the MailboxQuery class. This
has obviously incorrect results.
> Arguments to the isExpressionMatch method should be parsed to separate the namespace
from the mailbox name or isExpressionMatch should do the parsing itself. In that case the
argument name should be renamed to something like 'searchExpression' instead of 'name' which
doesn't convey the right meaning.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message