james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <server-...@james.apache.org>
Subject [jira] [Commented] (JAMES-1609) JMX unregister of queues : some queues are ignored.
Date Mon, 21 Sep 2015 08:41:04 GMT

    [ https://issues.apache.org/jira/browse/JAMES-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900386#comment-14900386
] 

ASF GitHub Bot commented on JAMES-1609:
---------------------------------------

GitHub user mbaechler opened a pull request:

    https://github.com/apache/james/pull/8

    JAMES-1609 Correct MBean un registry for mail queue factories

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mbaechler/james JAMES-1609

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/james/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #8
    
----
commit 671d40a3def901f6502970157c71eb29090e7f4c
Author: benwa <btellier@linagora.com>
Date:   2015-09-08T09:44:46Z

    JAMES-1609 Correct MBean un registry for mail queue factories

----


> JMX unregister of queues : some queues are ignored.
> ---------------------------------------------------
>
>                 Key: JAMES-1609
>                 URL: https://issues.apache.org/jira/browse/JAMES-1609
>             Project: James Server
>          Issue Type: Bug
>          Components: Queue
>    Affects Versions: Trunk
>            Reporter: Tellier Benoit
>             Fix For: Trunk
>
>
> The @PreDestoy method called look like this :
> ```
> for ( String mbean : mbeans) {
>     unregister(mbean);
>     mbeans.remove(mbean);
> }
> ```
> Causing mbeans being ignored and not unregistered.
> Solution is to simply not modify collection content while working on it and simply clear
it outside the for loop.
> Acceptance criteria :
>  - Being able to launch a James server, stop it and restart it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message